[PR #5560] [MERGED] fix: capture environment before request run #5256

New issue

Closed

opened 2026-03-17 02:43:22 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:43:22 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5560
Author: @nivedin
Created: 11/4/2025
Status: ✅ Merged
Merged: 11/11/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/req-run-env-update-bug

📝 Commits (5)

5746064 fix: capture env before request run
d5dd502 chore: update function
84edc85 chore: cleanup
dc97c87 fix: resolve typo in invocation
c8bbf42 chore: update env capture for test runner

📊 Changes

3 files changed (+230 additions, -62 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+0 -4)
📝 packages/hoppscotch-common/src/helpers/RequestRunner.ts (+216 -54)
📝 packages/hoppscotch-common/src/services/test-runner/test-runner.service.ts (+14 -4)

📄 Description

Closes #5528

This PR fixes a issue where environment variables were being incorrectly updated when users changed the active environment while a request was executing. Now we store the environment before a request run or a collection run.

What's changed

Notes to reviewers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5560 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 11/4/2025 **Status:** ✅ Merged **Merged:** 11/11/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/req-run-env-update-bug` --- ### 📝 Commits (5) - [`5746064`](https://github.com/hoppscotch/hoppscotch/commit/5746064fb7eb1ff052914e4ee48d1f529c61bbe8) fix: capture env before request run - [`d5dd502`](https://github.com/hoppscotch/hoppscotch/commit/d5dd5026318f58e2a43116cbde4c4ec52d8d2a6c) chore: update function - [`84edc85`](https://github.com/hoppscotch/hoppscotch/commit/84edc85045382af0d9a9d4156155aaf9bb37bbf9) chore: cleanup - [`dc97c87`](https://github.com/hoppscotch/hoppscotch/commit/dc97c8768487f233d25d854352f1a8f342854f5b) fix: resolve typo in invocation - [`c8bbf42`](https://github.com/hoppscotch/hoppscotch/commit/c8bbf42a3eafd13be4fc0a6ef9766e328ec35eea) chore: update env capture for test runner ### 📊 Changes **3 files changed** (+230 additions, -62 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+0 -4) 📝 `packages/hoppscotch-common/src/helpers/RequestRunner.ts` (+216 -54) 📝 `packages/hoppscotch-common/src/services/test-runner/test-runner.service.ts` (+14 -4) </details> ### 📄 Description   Closes #5528 This PR fixes a issue where environment variables were being incorrectly updated when users changed the active environment while a request was executing. Now we store the environment before a request run or a collection run. ### What's changed   ### Notes to reviewers  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>