[PR #5533] [MERGED] fix: team collection not loading on route change #5251

New issue

Closed

opened 2026-03-17 02:43:06 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:43:06 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5533
Author: @nivedin
Created: 10/30/2025
Status: ✅ Merged
Merged: 11/12/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/team-collection-load-bug

📝 Commits (8)

9886183 fix: team collection not loading on route change
4894be7 chore: check workspace changes and not personal
4016ae2 fix: cicular dep issue
8ee5bad chore: remove deep watch
1f6fdd9 chore: remove dynamic import
953cb42 fix: tests
bbed24f refactor: refactor: remove async from workspace sync callback
f5cc773 refactor: improve workspace equality type signature

📊 Changes

3 files changed (+312 additions, -25 deletions)

View changed files

📝 packages/hoppscotch-common/src/services/__tests__/workspace.service.spec.ts (+234 -0)
📝 packages/hoppscotch-common/src/services/team-collection.service.ts (+22 -25)
📝 packages/hoppscotch-common/src/services/workspace.service.ts (+56 -0)

📄 Description

Closes FE-1043 https://github.com/hoppscotch/hoppscotch/issues/5525

This PR fixes an issue where the collection service was not re-initialized when the route changed or when it unmounted, causing the collections to not update when the workspace was changed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5533 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 10/30/2025 **Status:** ✅ Merged **Merged:** 11/12/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/team-collection-load-bug` --- ### 📝 Commits (8) - [`9886183`](https://github.com/hoppscotch/hoppscotch/commit/9886183c27b4d4d30afadd74a9e9140b766b2e87) fix: team collection not loading on route change - [`4894be7`](https://github.com/hoppscotch/hoppscotch/commit/4894be792c62689bca539c71bbb8acf65791b87e) chore: check workspace changes and not personal - [`4016ae2`](https://github.com/hoppscotch/hoppscotch/commit/4016ae26fff1c0e2d3d505fea7bb6a125ea8965f) fix: cicular dep issue - [`8ee5bad`](https://github.com/hoppscotch/hoppscotch/commit/8ee5bad19c2d5cc4fcdfe0ea7a39808dee8b773d) chore: remove deep watch - [`1f6fdd9`](https://github.com/hoppscotch/hoppscotch/commit/1f6fdd96e08ba06da1909f1fbd66910b65713208) chore: remove dynamic import - [`953cb42`](https://github.com/hoppscotch/hoppscotch/commit/953cb422dc2740148da39ec8676d7fac1cc59d6f) fix: tests - [`bbed24f`](https://github.com/hoppscotch/hoppscotch/commit/bbed24f666dc31300e3fb03c4820685d4c75beb2) refactor: refactor: remove `async` from workspace sync callback - [`f5cc773`](https://github.com/hoppscotch/hoppscotch/commit/f5cc773f21e6a71da741f825dae7079416d9fe2b) refactor: improve workspace equality type signature ### 📊 Changes **3 files changed** (+312 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/services/__tests__/workspace.service.spec.ts` (+234 -0) 📝 `packages/hoppscotch-common/src/services/team-collection.service.ts` (+22 -25) 📝 `packages/hoppscotch-common/src/services/workspace.service.ts` (+56 -0) </details> ### 📄 Description Closes FE-1043 https://github.com/hoppscotch/hoppscotch/issues/5525 This PR fixes an issue where the collection service was not re-initialized when the route changed or when it unmounted, causing the collections to not update when the workspace was changed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>