[PR #5496] [MERGED] fix: reset `ONBOARDING_COMPLETED` to `false` during infra config reset #5238

New issue

Closed

opened 2026-03-17 02:42:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:42:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5496
Author: @mirarifhasan
Created: 10/20/2025
Status: ✅ Merged
Merged: 10/20/2025
Merged by: @mirarifhasan

Base: next ← Head: fix/reset-onboarding-completed-on-config-reset

📝 Commits (1)

c9be2c2 fix: reset ONBOARDING_COMPLETED config to false on reset

📊 Changes

1 file changed (+13 additions, -8 deletions)

View changed files

📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+13 -8)

📄 Description

Closes BE-668 #5495.

What's changed

This pull request updates the logic for resetting infrastructure configuration defaults in the InfraConfigService. The main improvement is ensuring that the ONBOARDING_COMPLETED configuration is explicitly set to false when performing a reset, which helps maintain a consistent onboarding state for users.

Improvements to infra config reset logic:

The reset logic now explicitly sets the value of ONBOARDING_COMPLETED to 'false' when resetting configuration defaults.
Refactored variable names for clarity (infraConfigDefaultObjs → defaultConfigs, updatedInfraConfigDefaultObjs → configsToReset).

Notes to reviewers

Please reset from the admin dashboard and check if the onboarding steps start

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5496 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 10/20/2025 **Status:** ✅ Merged **Merged:** 10/20/2025 **Merged by:** [@mirarifhasan](https://github.com/mirarifhasan) **Base:** `next` ← **Head:** `fix/reset-onboarding-completed-on-config-reset` --- ### 📝 Commits (1) - [`c9be2c2`](https://github.com/hoppscotch/hoppscotch/commit/c9be2c2acf719f74fcc746f109799371d851189b) fix: reset ONBOARDING_COMPLETED config to false on reset ### 📊 Changes **1 file changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+13 -8) </details> ### 📄 Description    Closes BE-668 #5495.  ### What's changed  This pull request updates the logic for resetting infrastructure configuration defaults in the `InfraConfigService`. The main improvement is ensuring that the `ONBOARDING_COMPLETED` configuration is explicitly set to `false` when performing a reset, which helps maintain a consistent onboarding state for users. **Improvements to infra config reset logic:** * The reset logic now explicitly sets the value of `ONBOARDING_COMPLETED` to `'false'` when resetting configuration defaults. * Refactored variable names for clarity (`infraConfigDefaultObjs` → `defaultConfigs`, `updatedInfraConfigDefaultObjs` → `configsToReset`).  ### Notes to reviewers  Please reset from the admin dashboard and check if the onboarding steps start --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>