[PR #5466] [MERGED] chore(backend): cleanup code quality issues #5221

New issue

Closed

opened 2026-03-17 02:41:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:41:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5466
Author: @abhishekmaniy
Created: 10/9/2025
Status: ✅ Merged
Merged: 10/27/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/microsoft-sso-guard-filename-typo

📝 Commits (4)

9cf61fb fix: remove extra dash from microsoft-sso guard filename
fae8428 fix: remove incomplete comment blocks in errors.ts
7878364 fix: add missing 'as const' assertions for consistency in errors.ts
bb7b2c6 fix: add missing parameter and return type annotations to setupSwagger

📊 Changes

4 files changed (+6 additions, -12 deletions)

View changed files

📝 packages/hoppscotch-backend/src/auth/auth.controller.ts (+1 -1)
📝 packages/hoppscotch-backend/src/auth/guards/microsoft-sso.guard.ts (+0 -0)
📝 packages/hoppscotch-backend/src/errors.ts (+4 -10)
📝 packages/hoppscotch-backend/src/main.ts (+1 -1)

📄 Description

Summary

Remove extra dash from microsoft-sso-.guard.ts filename
Update import path in auth.controller.ts to match corrected filename
Remove incomplete comment blocks (/* without closing */) in errors.ts
Standardize comment formatting throughout the file
Improve code readability and consistency
Add missing type annotation for app parameter as NestExpressApplication
Add explicit void return type annotation
Improve type safety and code documentation

Test plan

Verify file rename completed successfully
Confirm import statement updated correctly
Check that build/compilation works without errors

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5466 **Author:** [@abhishekmaniy](https://github.com/abhishekmaniy) **Created:** 10/9/2025 **Status:** ✅ Merged **Merged:** 10/27/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/microsoft-sso-guard-filename-typo` --- ### 📝 Commits (4) - [`9cf61fb`](https://github.com/hoppscotch/hoppscotch/commit/9cf61fb801cf6e540f0f4f8f0505fef4d3b2eb01) fix: remove extra dash from microsoft-sso guard filename - [`fae8428`](https://github.com/hoppscotch/hoppscotch/commit/fae8428228ca96e495d3b70c67088718cf627e7a) fix: remove incomplete comment blocks in errors.ts - [`7878364`](https://github.com/hoppscotch/hoppscotch/commit/78783643288498013b6e56d8a9e6288a00111e18) fix: add missing 'as const' assertions for consistency in errors.ts - [`bb7b2c6`](https://github.com/hoppscotch/hoppscotch/commit/bb7b2c61c17531743e6cee74def487a25015e092) fix: add missing parameter and return type annotations to setupSwagger ### 📊 Changes **4 files changed** (+6 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/auth/auth.controller.ts` (+1 -1) 📝 `packages/hoppscotch-backend/src/auth/guards/microsoft-sso.guard.ts` (+0 -0) 📝 `packages/hoppscotch-backend/src/errors.ts` (+4 -10) 📝 `packages/hoppscotch-backend/src/main.ts` (+1 -1) </details> ### 📄 Description ## Summary - Remove extra dash from `microsoft-sso-.guard.ts` filename - Update import path in `auth.controller.ts` to match corrected filename - Remove incomplete comment blocks (/* without closing */) in errors.ts - Standardize comment formatting throughout the file - Improve code readability and consistency - Add missing type annotation for `app` parameter as `NestExpressApplication` - Add explicit `void` return type annotation - Improve type safety and code documentation ## Test plan - [x] Verify file rename completed successfully - [x] Confirm import statement updated correctly - [x] Check that build/compilation works without errors --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>