[PR #5429] [CLOSED] Removed redundant imports from settings sync file #5205

Closed
opened 2026-03-17 02:40:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5429
Author: @Prit1912
Created: 10/2/2025
Status: Closed

Base: mainHead: fix/letmecheck/updated-imports-in-settings-sync-file


📝 Commits (1)

  • 48944f5 Removed redundant imports from settings sync file

📊 Changes

1 file changed (+1 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-selfhost-desktop/src/platform/settings/settings.sync.ts (+1 -3)

📄 Description

What's changed

File path: packages\hoppscotch-selfhost-desktop\src\platform\settings\settings.sync.ts
Fixed: Removed redundant lines of importing from same file

Before:
import { getSyncInitFunction } from "../../lib/sync"
import { StoreSyncDefinitionOf } from "../../lib/sync"

After:
import { getSyncInitFunction, type StoreSyncDefinitionOf } from "../../lib/sync"


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5429 **Author:** [@Prit1912](https://github.com/Prit1912) **Created:** 10/2/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/letmecheck/updated-imports-in-settings-sync-file` --- ### 📝 Commits (1) - [`48944f5`](https://github.com/hoppscotch/hoppscotch/commit/48944f5c49315edc090a91d96c26ba21a8948cca) Removed redundant imports from settings sync file ### 📊 Changes **1 file changed** (+1 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-desktop/src/platform/settings/settings.sync.ts` (+1 -3) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> <!-- Issue # here --> <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> <b>File path:</b> packages\hoppscotch-selfhost-desktop\src\platform\settings\settings.sync.ts <b>Fixed:</b> Removed redundant lines of importing from same file <b>Before:</b> import { getSyncInitFunction } from "../../lib/sync" import { StoreSyncDefinitionOf } from "../../lib/sync" <b> After: <b> import { getSyncInitFunction, type StoreSyncDefinitionOf } from "../../lib/sync" <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> <!-- Any information you feel the reviewer should know about when reviewing your PR --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:40:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#5205
No description provided.