[PR #5397] [MERGED] fix: ensure npm is installed for Node.js base image #5188

New issue

Closed

opened 2026-03-17 02:39:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:39:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5397
Author: @Leon-Luu
Created: 9/22/2025
Status: ✅ Merged
Merged: 9/24/2025
Merged by: @mirarifhasan

Base: next ← Head: fix/npm_install_failed_2025_8_0

📝 Commits (2)

410219a fix: ensure npm is installed for Node.js base image
fa0390e Apply suggestion from @Copilot

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 prod.Dockerfile (+3 -3)

📄 Description

This PR updates the prod.Dockerfile to explicitly install npm alongside nodejs in the Alpine base image.

On Alpine, nodejs does not include npm by default, which caused build failures when running npm install -g ....

The fix adds npm to the apk add command, ensuring the Node.js environment is complete and compatible with subsequent global package installations.

Closes #
https://github.com/hoppscotch/hoppscotch/issues/5396

What's changed

Add npm to the apk add --no-cache nodejs npm curl tini bash command in the Node.js base stage.
This resolves /bin/sh: npm: not found errors during Docker builds in CI and local environments.

Notes to reviewers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5397 **Author:** [@Leon-Luu](https://github.com/Leon-Luu) **Created:** 9/22/2025 **Status:** ✅ Merged **Merged:** 9/24/2025 **Merged by:** [@mirarifhasan](https://github.com/mirarifhasan) **Base:** `next` ← **Head:** `fix/npm_install_failed_2025_8_0` --- ### 📝 Commits (2) - [`410219a`](https://github.com/hoppscotch/hoppscotch/commit/410219a232469b2ffef0de6b99847f5d6641410e) fix: ensure npm is installed for Node.js base image - [`fa0390e`](https://github.com/hoppscotch/hoppscotch/commit/fa0390e93cf1268f7df79dfb3ae5d0d9337a09cb) Apply suggestion from @Copilot ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `prod.Dockerfile` (+3 -3) </details> ### 📄 Description  This PR updates the [prod.Dockerfile](vscode-file://vscode-app/c:/Users/LELUU2/AppData/Local/Programs/Microsoft%20VS%20Code/resources/app/out/vs/code/electron-browser/workbench/workbench.html) to explicitly install npm alongside nodejs in the Alpine base image. On Alpine, nodejs does not include npm by default, which caused build failures when running npm install -g .... The fix adds npm to the apk add command, ensuring the Node.js environment is complete and compatible with subsequent global package installations.  Closes #  https://github.com/hoppscotch/hoppscotch/issues/5396  ### What's changed  Add npm to the apk add --no-cache nodejs npm curl tini bash command in the Node.js base stage. This resolves /bin/sh: npm: not found errors during Docker builds in CI and local environments.  ### Notes to reviewers  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>