[PR #5348] [MERGED] fix: handle edge cases and bugs in collection variables #5171

New issue

Closed

opened 2026-03-17 02:38:45 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:38:45 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5348
Author: @nivedin
Created: 8/25/2025
Status: ✅ Merged
Merged: 8/26/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/coll-var-edge-cases

📝 Commits (10+)

f460fa7 fix: coll-var import from team workspace bug
575d275 chore: hide action button for coll env inspector
69b60e4 fix: collection move coll var and req var priority bug
09f6be8 fix: collection variable priority issue
3121c65 fix: team collction tab inheritance bug while moving
f32e57b chore: use function for duplicated calls
6b68d83 chore: update function and add comment
2875821 remove extra asterik
5ee76b4 Capitalize text
35d8707 remove extra asterik

📊 Changes

18 files changed (+610 additions, -539 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/app/Inspection.vue (+5 -2)
📝 packages/hoppscotch-common/src/components/collections/TeamCollections.vue (+23 -7)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+40 -11)
📝 packages/hoppscotch-common/src/components/importExport/ImportExportSteps/AllCollectionImport.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/smart/EnvInput.vue (+35 -16)
📝 packages/hoppscotch-common/src/helpers/backend/gql/subscriptions/TeamCollectionMoved.graphql (+1 -0)
📝 packages/hoppscotch-common/src/helpers/collection/collection.ts (+76 -8)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts (+87 -60)
📝 packages/hoppscotch-common/src/helpers/import-export/import/openapi/example-generators/v2.ts (+1 -1)
📝 packages/hoppscotch-common/src/helpers/teams/TeamCollection.ts (+1 -1)
📝 packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts (+12 -10)
📝 packages/hoppscotch-common/src/helpers/types/HoppInheritedProperties.ts (+1 -0)
📝 packages/hoppscotch-common/src/helpers/utils/inheritedCollectionVarTransformer.ts (+19 -8)
📝 packages/hoppscotch-common/src/newstore/collections.ts (+12 -20)
📝 packages/hoppscotch-common/src/newstore/environments.ts (+57 -161)
📝 packages/hoppscotch-common/src/services/inspection/index.ts (+1 -0)
📝 packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts (+232 -234)
📝 packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts (+1 -0)

📄 Description

Closes FE-992

This PR fixes some edge cases and bug's with collection variables

Import from 'Another Workspace' to Team workspace fails to import collection variables
Hide action button in collection variable empty inspector (can be iterated in future to open the collection properties)
Add collection variable when moving or reordering personal collection
opened tabs in team collection variable when moving does not get updated.
Collection request variable priority bug over collection var

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5348 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 8/25/2025 **Status:** ✅ Merged **Merged:** 8/26/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/coll-var-edge-cases` --- ### 📝 Commits (10+) - [`f460fa7`](https://github.com/hoppscotch/hoppscotch/commit/f460fa79a4c055af5e488e9a033c32656db6847f) fix: coll-var import from team workspace bug - [`575d275`](https://github.com/hoppscotch/hoppscotch/commit/575d27525586b031fd018a6d526a51de29a1fc68) chore: hide action button for coll env inspector - [`69b60e4`](https://github.com/hoppscotch/hoppscotch/commit/69b60e4bead8bd7c0a857b58acf79b261f9f3cdf) fix: collection move coll var and req var priority bug - [`09f6be8`](https://github.com/hoppscotch/hoppscotch/commit/09f6be88bc0b4d3858aaa4984a517fe4076841a0) fix: collection variable priority issue - [`3121c65`](https://github.com/hoppscotch/hoppscotch/commit/3121c652ee28374560ecdb5bfea26691d037751f) fix: team collction tab inheritance bug while moving - [`f32e57b`](https://github.com/hoppscotch/hoppscotch/commit/f32e57b27b59ab6c1d4423662d0a7e9d7643581c) chore: use function for duplicated calls - [`6b68d83`](https://github.com/hoppscotch/hoppscotch/commit/6b68d83f696bea22880de388c93c2697089e7b19) chore: update function and add comment - [`2875821`](https://github.com/hoppscotch/hoppscotch/commit/287582122cd8056af2b7811e2c87979b41dd5523) remove extra asterik - [`5ee76b4`](https://github.com/hoppscotch/hoppscotch/commit/5ee76b4385bc42261c53f3038d885e5ecfbcd082) Capitalize text - [`35d8707`](https://github.com/hoppscotch/hoppscotch/commit/35d87078283d3c4d2fc63ac8e026f06fe142a138) remove extra asterik ### 📊 Changes **18 files changed** (+610 additions, -539 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/app/Inspection.vue` (+5 -2) 📝 `packages/hoppscotch-common/src/components/collections/TeamCollections.vue` (+23 -7) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+40 -11) 📝 `packages/hoppscotch-common/src/components/importExport/ImportExportSteps/AllCollectionImport.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/smart/EnvInput.vue` (+35 -16) 📝 `packages/hoppscotch-common/src/helpers/backend/gql/subscriptions/TeamCollectionMoved.graphql` (+1 -0) 📝 `packages/hoppscotch-common/src/helpers/collection/collection.ts` (+76 -8) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts` (+87 -60) 📝 `packages/hoppscotch-common/src/helpers/import-export/import/openapi/example-generators/v2.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollection.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/teams/TeamCollectionAdapter.ts` (+12 -10) 📝 `packages/hoppscotch-common/src/helpers/types/HoppInheritedProperties.ts` (+1 -0) 📝 `packages/hoppscotch-common/src/helpers/utils/inheritedCollectionVarTransformer.ts` (+19 -8) 📝 `packages/hoppscotch-common/src/newstore/collections.ts` (+12 -20) 📝 `packages/hoppscotch-common/src/newstore/environments.ts` (+57 -161) 📝 `packages/hoppscotch-common/src/services/inspection/index.ts` (+1 -0) 📝 `packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts` (+232 -234) 📝 `packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts` (+1 -0) </details> ### 📄 Description Closes FE-992 This PR fixes some edge cases and bug's with collection variables - [x] Import from 'Another Workspace' to Team workspace fails to import collection variables - [x] Hide action button in collection variable empty inspector (can be iterated in future to open the collection properties) - [x] Add collection variable when moving or reordering personal collection - [x] opened tabs in team collection variable when moving does not get updated. - [x] Collection request variable priority bug over collection var --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>