[PR #5290] [MERGED] fix: SH admin dashboard setting and onboarding page cleanups #5145

New issue

Closed

opened 2026-03-17 02:37:07 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:37:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5290
Author: @nivedin
Created: 7/29/2025
Status: ✅ Merged
Merged: 7/29/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/onboarding-cleanup

📝 Commits (9)

d9e1ce8 chore: login page cleanup
b2c37ff fix: smtp required field bug
4a95d93 chore: update validation check
1e0b8bd chore: auto open accordian if selected in prev step
b2ad771 chore: disable autofocus on SMTP input fields
24069ab chore: cleanup auth component
7d98135 fix: adjust text size for onboarding description
9d9ba19 chore: cleanup
705a55d chore: remove console logs

📊 Changes

10 files changed (+360 additions, -274 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/firebase/Login.vue (+6 -2)
📝 packages/hoppscotch-sh-admin/locales/en.json (+4 -2)
➕ packages/hoppscotch-sh-admin/src/components/onboarding/AuthProviderCard.vue (+46 -0)
📝 packages/hoppscotch-sh-admin/src/components/onboarding/AuthSetup.vue (+197 -233)
📝 packages/hoppscotch-sh-admin/src/components/onboarding/CompleteScreen.vue (+2 -2)
📝 packages/hoppscotch-sh-admin/src/components/onboarding/SmtpSetup.vue (+2 -0)
📝 packages/hoppscotch-sh-admin/src/components/settings/RateLimit.vue (+0 -2)
📝 packages/hoppscotch-sh-admin/src/components/ui/Accordion.vue (+48 -14)
📝 packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts (+48 -14)
📝 packages/hoppscotch-sh-admin/src/composables/useOnboardingConfigHandler.ts (+7 -5)

📄 Description

This PR fixes some minor issues in SH dashboard side and the Login component

Show helper text if no auth providers are found (this include OIDC and SAML)
Show update button bug in dashboard setting if the rate_limit values does not change
SMTP bug in dashboard in advance option is selected case
Add step view for onboarding flow

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5290 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 7/29/2025 **Status:** ✅ Merged **Merged:** 7/29/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/onboarding-cleanup` --- ### 📝 Commits (9) - [`d9e1ce8`](https://github.com/hoppscotch/hoppscotch/commit/d9e1ce810a48cd9aef33dbf90e149a813d46c827) chore: login page cleanup - [`b2c37ff`](https://github.com/hoppscotch/hoppscotch/commit/b2c37ff4689724aca6b0eb1ba06780fae2d138da) fix: smtp required field bug - [`4a95d93`](https://github.com/hoppscotch/hoppscotch/commit/4a95d93576f898943da911a88c40f086ed542b91) chore: update validation check - [`1e0b8bd`](https://github.com/hoppscotch/hoppscotch/commit/1e0b8bd96b43e7edbfdd044a6d816bc3329e74e7) chore: auto open accordian if selected in prev step - [`b2ad771`](https://github.com/hoppscotch/hoppscotch/commit/b2ad771ae8b18039872b3379c5355d7038044876) chore: disable autofocus on SMTP input fields - [`24069ab`](https://github.com/hoppscotch/hoppscotch/commit/24069ab59d434d70ff8d61445f51e6f73b91b08b) chore: cleanup auth component - [`7d98135`](https://github.com/hoppscotch/hoppscotch/commit/7d98135c06533e4a4cd88a8d4f5c9fe4c648bba7) fix: adjust text size for onboarding description - [`9d9ba19`](https://github.com/hoppscotch/hoppscotch/commit/9d9ba19e6218cd31c65da7649ab2ee177300013c) chore: cleanup - [`705a55d`](https://github.com/hoppscotch/hoppscotch/commit/705a55d5d8e6e13556af764fa95c10e7253b9c23) chore: remove console logs ### 📊 Changes **10 files changed** (+360 additions, -274 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/firebase/Login.vue` (+6 -2) 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+4 -2) ➕ `packages/hoppscotch-sh-admin/src/components/onboarding/AuthProviderCard.vue` (+46 -0) 📝 `packages/hoppscotch-sh-admin/src/components/onboarding/AuthSetup.vue` (+197 -233) 📝 `packages/hoppscotch-sh-admin/src/components/onboarding/CompleteScreen.vue` (+2 -2) 📝 `packages/hoppscotch-sh-admin/src/components/onboarding/SmtpSetup.vue` (+2 -0) 📝 `packages/hoppscotch-sh-admin/src/components/settings/RateLimit.vue` (+0 -2) 📝 `packages/hoppscotch-sh-admin/src/components/ui/Accordion.vue` (+48 -14) 📝 `packages/hoppscotch-sh-admin/src/composables/useConfigHandler.ts` (+48 -14) 📝 `packages/hoppscotch-sh-admin/src/composables/useOnboardingConfigHandler.ts` (+7 -5) </details> ### 📄 Description This PR fixes some minor issues in SH dashboard side and the Login component - Show helper text if no auth providers are found (this include OIDC and SAML) - Show update button bug in dashboard setting if the rate_limit values does not change - SMTP bug in dashboard in advance option is selected case - Add step view for onboarding flow --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>