[PR #5229] [MERGED] feat(desktop): tab shortcuts discoverability #5118

New issue

Closed

opened 2026-03-17 02:35:43 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:35:43 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5229
Author: @CuriousCorrelation
Created: 7/8/2025
Status: ✅ Merged
Merged: 7/9/2025
Merged by: @jamesgeorge007

Base: patch ← Head: feat-desktop-discover-keyboard-shortcuts

📝 Commits (1)

bc39355 feat(desktop): tab shortcuts discoverability

📊 Changes

2 files changed (+53 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/locales/en.json (+10 -0)
📝 packages/hoppscotch-common/src/helpers/shortcuts.ts (+43 -2)

📄 Description

This adds tab navigation shortcuts to the shortcuts help dialog for desktop users and conditionally shows them only in desktop mode.

Web app	Desktop app

The shortcuts help now includes a "Tabs" section with all available tab management shortcuts, but only displays them when running in desktop kernel mode to avoid confusing web users with non-functional shortcuts.

Closes FE-917

The desktop app already had functional tab navigation shortcuts, but they weren't documented in the app's shortcuts help dialog (accessible via ? or Cmd/Ctrl+/). This made the shortcuts less discoverable for users who wanted to learn about available keyboard controls.

The shortcuts helper now uses getKernelMode() to determine whether to include desktop-specific shortcuts in the help dialog.

The call to getKernelMode() is quite cheap so there won't be any issues if the call was made during every re-render.

What's changed

Added conditional shortcut loading in shortcuts.ts based on kernel mode detection
Added "Tabs" section translations to en.json with all tab navigation shortcuts
Implemented desktop-only shortcut filtering so web users only see applicable shortcuts

Implementation

The solution splits shortcuts into baseShortcuts (available on all platforms) and desktopShortcuts (desktop-only), then conditionally combines them based on the current kernel mode.

Notes to reviewers

This change only affects the shortcuts help dialog display and doesn't modify any functional behavior. All existing shortcuts continue to work exactly as before.

Testing should verify that Desktop app shows the new "Tabs" section in shortcuts help and Web app doesn't.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5229 **Author:** [@CuriousCorrelation](https://github.com/CuriousCorrelation) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/9/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `feat-desktop-discover-keyboard-shortcuts` --- ### 📝 Commits (1) - [`bc39355`](https://github.com/hoppscotch/hoppscotch/commit/bc39355bfc5a4bcb87307665739cadc3afad2639) feat(desktop): tab shortcuts discoverability ### 📊 Changes **2 files changed** (+53 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/en.json` (+10 -0) 📝 `packages/hoppscotch-common/src/helpers/shortcuts.ts` (+43 -2) </details> ### 📄 Description This adds tab navigation shortcuts to the shortcuts help dialog for desktop users and conditionally shows them only in desktop mode. | Web app | Desktop app | | --- | --- | | ![image](https://github.com/user-attachments/assets/97c15625-b323-4bc0-9382-78cf1fd78ae4) | ![image](https://github.com/user-attachments/assets/4211aa82-2b24-4472-bc30-94b94accda9d) | The shortcuts help now includes a "Tabs" section with all available tab management shortcuts, but only displays them when running in desktop kernel mode to avoid confusing web users with non-functional shortcuts. Closes FE-917 The desktop app already had functional tab navigation shortcuts, but they weren't documented in the app's shortcuts help dialog (accessible via `?` or `Cmd/Ctrl+/`). This made the shortcuts less discoverable for users who wanted to learn about available keyboard controls. The shortcuts helper now uses `getKernelMode()` to determine whether to include desktop-specific shortcuts in the help dialog. The call to `getKernelMode()` is quite cheap so there won't be any issues if the call was made during every re-render. ### What's changed - Added conditional shortcut loading in `shortcuts.ts` based on kernel mode detection - Added "Tabs" section translations to `en.json` with all tab navigation shortcuts - Implemented desktop-only shortcut filtering so web users only see applicable shortcuts ### Implementation The solution splits shortcuts into `baseShortcuts` (available on all platforms) and `desktopShortcuts` (desktop-only), then conditionally combines them based on the current kernel mode. ### Notes to reviewers This change only affects the shortcuts help dialog display and doesn't modify any functional behavior. All existing shortcuts continue to work exactly as before. Testing should verify that Desktop app shows the new "Tabs" section in shortcuts help and Web app doesn't. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>