[PR #5231] [MERGED] fix: allow aws signature to work with query params #5117

Closed
opened 2026-03-17 02:35:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5231
Author: @rafalaidlaw
Created: 7/8/2025
Status: Merged
Merged: 7/27/2025
Merged by: @jamesgeorge007

Base: nextHead: task/aws-signature-bug


📝 Commits (4)

  • f33fbb3 fix: allow aws signature to work with query params
  • e26c592 refactor: extract query parameter processing into a separate function
  • dbf7ca8 chore: simplify aws signature tests with helper functions
  • c4fbe93 chore: cleanup

📊 Changes

2 files changed (+529 additions, -41 deletions)

View changed files

packages/hoppscotch-common/src/helpers/auth/types/__tests__/aws-signature.spec.ts (+431 -0)
📝 packages/hoppscotch-common/src/helpers/auth/types/aws-signature.ts (+98 -41)

📄 Description

Closes #4668

What's changed

Implemented query handling for aws signature authentication, added tests


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5231 **Author:** [@rafalaidlaw](https://github.com/rafalaidlaw) **Created:** 7/8/2025 **Status:** ✅ Merged **Merged:** 7/27/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `task/aws-signature-bug` --- ### 📝 Commits (4) - [`f33fbb3`](https://github.com/hoppscotch/hoppscotch/commit/f33fbb359a46adae80481d2465a105ed6400b67b) fix: allow aws signature to work with query params - [`e26c592`](https://github.com/hoppscotch/hoppscotch/commit/e26c5923b6aea2461c7bc5b09ad5133ed8633f46) refactor: extract query parameter processing into a separate function - [`dbf7ca8`](https://github.com/hoppscotch/hoppscotch/commit/dbf7ca87c91f374dcd8a3e1c7e84558a769e3b93) chore: simplify aws signature tests with helper functions - [`c4fbe93`](https://github.com/hoppscotch/hoppscotch/commit/c4fbe930c7c0cbc6e954581879a25bbbb40f653d) chore: cleanup ### 📊 Changes **2 files changed** (+529 additions, -41 deletions) <details> <summary>View changed files</summary> ➕ `packages/hoppscotch-common/src/helpers/auth/types/__tests__/aws-signature.spec.ts` (+431 -0) 📝 `packages/hoppscotch-common/src/helpers/auth/types/aws-signature.ts` (+98 -41) </details> ### 📄 Description Closes #4668 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed Implemented query handling for aws signature authentication, added tests --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:35:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#5117
No description provided.