[PR #5187] [MERGED] chore: resolve global env in team env and tooltip UI update #5100

Closed
opened 2026-03-17 02:34:38 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5187
Author: @nivedin
Created: 6/23/2025
Status: Merged
Merged: 6/25/2025
Merged by: @jamesgeorge007

Base: nextHead: fix/tooltip-env-bug


📝 Commits (6)

  • b9d2cd6 chore: resolve global env in team env
  • a1c4543 chore: improve environment tooltip UI
  • 99e2546 chore: cleanup
  • d4b820a fix: predefined var tooltip UI update
  • ce5a662 chore: add initial current val in selector
  • 59e0729 chore: cleanup

📊 Changes

11 files changed (+303 additions, -135 deletions)

View changed files

📝 packages/hoppscotch-common/assets/scss/styles.scss (+1 -2)
📝 packages/hoppscotch-common/locales/en.json (+2 -0)
📝 packages/hoppscotch-common/src/components/environments/Selector.vue (+28 -6)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+10 -1)
📝 packages/hoppscotch-common/src/components/smart/EnvInput.vue (+10 -6)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts (+122 -41)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppPredefinedVariables.ts (+43 -12)
📝 packages/hoppscotch-common/src/newstore/environments.ts (+73 -43)
📝 packages/hoppscotch-common/src/services/inspection/inspectors/__tests__/environment.inspector.spec.ts (+1 -1)
📝 packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts (+11 -9)
📝 packages/hoppscotch-data/src/environment/index.ts (+2 -14)

📄 Description

Closes HFE-906 #4723

This PR fixes the issue with global environments not getting resolve while using in a shared workspace environment as a nested environment (ref).

This PR also improves the UI of the environment tooltip by including initial and current environment value with proper info about the environment.

https://github.com/user-attachments/assets/b421f081-5f6c-4cd5-b79b-2691281330a6


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5187 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 6/23/2025 **Status:** ✅ Merged **Merged:** 6/25/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/tooltip-env-bug` --- ### 📝 Commits (6) - [`b9d2cd6`](https://github.com/hoppscotch/hoppscotch/commit/b9d2cd62eecd16c0305153c3da1c310b6302c8ec) chore: resolve global env in team env - [`a1c4543`](https://github.com/hoppscotch/hoppscotch/commit/a1c4543fa68fa218e0ccaf948290e10e1a15f713) chore: improve environment tooltip UI - [`99e2546`](https://github.com/hoppscotch/hoppscotch/commit/99e2546b3cd818022a428be36349bfd11dc666e1) chore: cleanup - [`d4b820a`](https://github.com/hoppscotch/hoppscotch/commit/d4b820ae594359f1e988127fe4ee5cfe1312f860) fix: predefined var tooltip UI update - [`ce5a662`](https://github.com/hoppscotch/hoppscotch/commit/ce5a662c5069f1ca01f30f5629ff180e18457095) chore: add initial current val in selector - [`59e0729`](https://github.com/hoppscotch/hoppscotch/commit/59e07295cc98ff95cce8b46b1f6dfdca5dc04440) chore: cleanup ### 📊 Changes **11 files changed** (+303 additions, -135 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/assets/scss/styles.scss` (+1 -2) 📝 `packages/hoppscotch-common/locales/en.json` (+2 -0) 📝 `packages/hoppscotch-common/src/components/environments/Selector.vue` (+28 -6) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+10 -1) 📝 `packages/hoppscotch-common/src/components/smart/EnvInput.vue` (+10 -6) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts` (+122 -41) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppPredefinedVariables.ts` (+43 -12) 📝 `packages/hoppscotch-common/src/newstore/environments.ts` (+73 -43) 📝 `packages/hoppscotch-common/src/services/inspection/inspectors/__tests__/environment.inspector.spec.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/services/inspection/inspectors/environment.inspector.ts` (+11 -9) 📝 `packages/hoppscotch-data/src/environment/index.ts` (+2 -14) </details> ### 📄 Description Closes HFE-906 #4723 This PR fixes the issue with global environments not getting resolve while using in a shared workspace environment as a nested environment ([ref](https://github.com/hoppscotch/hoppscotch/issues/4723#issuecomment-2990197241)). This PR also improves the UI of the environment tooltip by including initial and current environment value with proper info about the environment. https://github.com/user-attachments/assets/b421f081-5f6c-4cd5-b79b-2691281330a6 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:34:38 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#5100
No description provided.