[PR #5157] [MERGED] fix: add fallback for `isSecret` key #5085

New issue

Closed

opened 2026-03-17 02:33:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:33:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5157
Author: @nivedin
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/16/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/current-value-schema-error

📝 Commits (1)

4249eae fix: add fallback for isSecret schema

📊 Changes

4 files changed (+4 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/my/Details.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+1 -1)
📝 packages/hoppscotch-common/src/helpers/RequestRunner.ts (+1 -1)
📝 packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts (+1 -1)

📄 Description

This PR fixes an issue with schema validation failing in some edge cases where isSecret value get null, and default value to false is added in that case now for CurrentValue persistance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5157 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/16/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/current-value-schema-error` --- ### 📝 Commits (1) - [`4249eae`](https://github.com/hoppscotch/hoppscotch/commit/4249eaeab2c5a127eb15b275fd5d892fa1ecee49) fix: add fallback for isSecret schema ### 📊 Changes **4 files changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/my/Details.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/RequestRunner.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts` (+1 -1) </details> ### 📄 Description This PR fixes an issue with schema validation failing in some edge cases where isSecret value get null, and default value to false is added in that case now for CurrentValue persistance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>