[PR #5154] [MERGED] fix: auth tokens not propagating to child requests #5081

New issue

Closed

opened 2026-03-17 02:33:49 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:33:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5154
Author: @mayank-jain-1010
Created: 6/16/2025
Status: ✅ Merged
Merged: 6/17/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/auth-tokens-not-propagating-to-child-requests

📝 Commits (3)

c4540ee fix: auth tokens not propagating to child requests
bb246fd chore: cleanup
10c1b01 refactor: remove redundant optional chaining

📊 Changes

2 files changed (+8 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/Properties.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/collections/index.vue (+7 -2)

📄 Description

Closes #3957

Access tokens are not propagated to child requests when using OAuth2.0 authorization. This behavior is observed for Team Workspaces only.

What's changed

During the callback from auth provider to the Hoppscotch application (at route /oauth), collection.id is not preserved
As the variable path is preserved, we use that to deduce the value of collectionId

Notes to reviewers

Video demonstrating the fix:

https://github.com/user-attachments/assets/dd6524e2-b19b-4101-ac34-22836865d9e9

Key things to note in the video:

Access token now remains preserved in collection properties dialog box after clicking on the save button
Auth type of inherit on a child request would now successfully point to this access token

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5154 **Author:** [@mayank-jain-1010](https://github.com/mayank-jain-1010) **Created:** 6/16/2025 **Status:** ✅ Merged **Merged:** 6/17/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/auth-tokens-not-propagating-to-child-requests` --- ### 📝 Commits (3) - [`c4540ee`](https://github.com/hoppscotch/hoppscotch/commit/c4540ee224ca341953039c001fbc54241d46ed2d) fix: auth tokens not propagating to child requests - [`bb246fd`](https://github.com/hoppscotch/hoppscotch/commit/bb246fdb42516a6e7d120284e7461329053c0d6e) chore: cleanup - [`10c1b01`](https://github.com/hoppscotch/hoppscotch/commit/10c1b013e2ae23ab68220bc39e8910c2ba05944d) refactor: remove redundant optional chaining ### 📊 Changes **2 files changed** (+8 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/Properties.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/collections/index.vue` (+7 -2) </details> ### 📄 Description Closes #3957 Access tokens are not propagated to child requests when using `OAuth2.0 authorization`. This behavior is observed for `Team Workspaces` only. ### What's changed - During the callback from auth provider to the Hoppscotch application (at route `/oauth`), `collection.id` is not preserved - As the variable `path` is preserved, we use that to deduce the value of `collectionId` ### Notes to reviewers **Video demonstrating the fix:** https://github.com/user-attachments/assets/dd6524e2-b19b-4101-ac34-22836865d9e9 Key things to note in the video: - Access token now remains preserved in collection properties dialog box after clicking on the save button - Auth type of inherit on a child request would now successfully point to this access token --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>