[PR #5037] [MERGED] feat(common): platform ui definition for team edit and invite #5027

New issue

Closed

opened 2026-03-17 02:30:50 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:30:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/5037
Author: @anwarulislam
Created: 4/30/2025
Status: ✅ Merged
Merged: 5/2/2025
Merged by: @jamesgeorge007

Base: next ← Head: feat/platform-specific-ui-definition

📝 Commits (9)

67e89dc feat: graphql poll loading controller added
ddcc7b2 feat: platform specific team ui config added
28ed617 feat: ux imporvements by changing polling behavior
aac2bc3 refactor: replace string literals with TeamMemberRole constants in member role updates
1c5aa6a feat: implement platform-specific components for team editing and inviting
a249ee8 chore: clean up
a4ea00e feat: prefix with additional to the platform UI definition
3e8531e chore: clean up
6ae668c chore: cleanup

📊 Changes

6 files changed (+117 additions, -26 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/app/Header.vue (+33 -4)
📝 packages/hoppscotch-common/src/components/teams/Edit.vue (+13 -3)
📝 packages/hoppscotch-common/src/components/teams/Invite.vue (+1 -0)
📝 packages/hoppscotch-common/src/components/teams/index.vue (+44 -18)
📝 packages/hoppscotch-common/src/composables/graphql.ts (+16 -1)
📝 packages/hoppscotch-common/src/platform/ui.ts (+10 -0)

📄 Description

This pull request introduces support for custom UI components for team invite and edit functionality, improved GraphQL query behavior. Below is a summary of the most important changes grouped by theme:

Code Refactoring:

Replaced hardcoded role strings ('OWNER', 'EDITOR', 'VIEWER') with the TeamMemberRole enum for better type safety and readability. (packages/hoppscotch-common/src/components/teams/Edit.vue, [1] [2] [3]

These changes collectively enhance the flexibility, maintainability, and performance of the team management features.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/5037 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 4/30/2025 **Status:** ✅ Merged **Merged:** 5/2/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `feat/platform-specific-ui-definition` --- ### 📝 Commits (9) - [`67e89dc`](https://github.com/hoppscotch/hoppscotch/commit/67e89dc5d8edb06d9d4047d3035f2d4a7b93cf30) feat: graphql poll loading controller added - [`ddcc7b2`](https://github.com/hoppscotch/hoppscotch/commit/ddcc7b2f886eab7faf347596527ed4dff35efa64) feat: platform specific team ui config added - [`28ed617`](https://github.com/hoppscotch/hoppscotch/commit/28ed617b56bd15ce4fe4addef835c863137d7e4a) feat: ux imporvements by changing polling behavior - [`aac2bc3`](https://github.com/hoppscotch/hoppscotch/commit/aac2bc316736e598e88180108c0e73cc6d5caacc) refactor: replace string literals with TeamMemberRole constants in member role updates - [`1c5aa6a`](https://github.com/hoppscotch/hoppscotch/commit/1c5aa6a8eda23aca7223f2d5e8a8e89942ad2b04) feat: implement platform-specific components for team editing and inviting - [`a249ee8`](https://github.com/hoppscotch/hoppscotch/commit/a249ee86151585e4c6c66edd9b3e7f155fb7fbab) chore: clean up - [`a4ea00e`](https://github.com/hoppscotch/hoppscotch/commit/a4ea00e2a3780180861cdcb1abe9757f359db980) feat: prefix with additional to the platform UI definition - [`3e8531e`](https://github.com/hoppscotch/hoppscotch/commit/3e8531e5f2bb1c410a229213a8a643c675d73f96) chore: clean up - [`6ae668c`](https://github.com/hoppscotch/hoppscotch/commit/6ae668c0691f9af888d285a2467c3b5fe555ee20) chore: cleanup ### 📊 Changes **6 files changed** (+117 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/app/Header.vue` (+33 -4) 📝 `packages/hoppscotch-common/src/components/teams/Edit.vue` (+13 -3) 📝 `packages/hoppscotch-common/src/components/teams/Invite.vue` (+1 -0) 📝 `packages/hoppscotch-common/src/components/teams/index.vue` (+44 -18) 📝 `packages/hoppscotch-common/src/composables/graphql.ts` (+16 -1) 📝 `packages/hoppscotch-common/src/platform/ui.ts` (+10 -0) </details> ### 📄 Description This pull request introduces support for custom UI components for team invite and edit functionality, improved GraphQL query behavior. Below is a summary of the most important changes grouped by theme: ### Code Refactoring: * Replaced hardcoded role strings (`'OWNER'`, `'EDITOR'`, `'VIEWER'`) with the `TeamMemberRole` enum for better type safety and readability. (`packages/hoppscotch-common/src/components/teams/Edit.vue`, [[1]](diffhunk://#diff-cb9c050f11dee81270e534eb989340c0a9070a070334fdebbb796fc813a8e4f5L104-R107) [[2]](diffhunk://#diff-cb9c050f11dee81270e534eb989340c0a9070a070334fdebbb796fc813a8e4f5L117-R123) [[3]](diffhunk://#diff-cb9c050f11dee81270e534eb989340c0a9070a070334fdebbb796fc813a8e4f5L130-R139) These changes collectively enhance the flexibility, maintainability, and performance of the team management features. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>