[PR #4995] [MERGED] fix(common): refine profile field validations #5012

New issue

Closed

opened 2026-03-17 02:30:01 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:30:01 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4995
Author: @NayanUnni95
Created: 4/14/2025
Status: ✅ Merged
Merged: 4/15/2025
Merged by: @jamesgeorge007

Base: patch ← Head: bug

📝 Commits (1)

ef049ac fix(common): update profile details logic and add messages for all languages

📊 Changes

32 files changed (+79 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-common/locales/af.json (+2 -0)
📝 packages/hoppscotch-common/locales/ar.json (+2 -0)
📝 packages/hoppscotch-common/locales/ca.json (+2 -0)
📝 packages/hoppscotch-common/locales/cn.json (+2 -0)
📝 packages/hoppscotch-common/locales/cs.json (+2 -0)
📝 packages/hoppscotch-common/locales/da.json (+2 -0)
📝 packages/hoppscotch-common/locales/de.json (+2 -0)
📝 packages/hoppscotch-common/locales/el.json (+2 -0)
📝 packages/hoppscotch-common/locales/en.json (+2 -0)
📝 packages/hoppscotch-common/locales/es.json (+2 -0)
📝 packages/hoppscotch-common/locales/fi.json (+2 -0)
📝 packages/hoppscotch-common/locales/fr.json (+2 -0)
📝 packages/hoppscotch-common/locales/he.json (+2 -0)
📝 packages/hoppscotch-common/locales/hu.json (+2 -0)
📝 packages/hoppscotch-common/locales/id.json (+2 -0)
📝 packages/hoppscotch-common/locales/it.json (+2 -0)
📝 packages/hoppscotch-common/locales/ja.json (+2 -0)
📝 packages/hoppscotch-common/locales/ko.json (+2 -0)
📝 packages/hoppscotch-common/locales/nl.json (+2 -0)
📝 packages/hoppscotch-common/locales/no.json (+2 -0)

...and 12 more files

📄 Description

Closes #4994

The web app doesn't properly check if the email address is empty or the same. This also causes an unnecessary request to the server. I need to add checks to prevent saving empty or unchanged email addresses and avoid that extra server call.
Also, includes relevant i18n string additions.

What's changed

Implemented validation for empty or identical emails before the API call.

Notes to reviewers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4995 **Author:** [@NayanUnni95](https://github.com/NayanUnni95) **Created:** 4/14/2025 **Status:** ✅ Merged **Merged:** 4/15/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `bug` --- ### 📝 Commits (1) - [`ef049ac`](https://github.com/hoppscotch/hoppscotch/commit/ef049acd46df1f82314b2751458a9e8b8c76a23e) fix(common): update profile details logic and add messages for all languages ### 📊 Changes **32 files changed** (+79 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/locales/af.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/ar.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/ca.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/cn.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/cs.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/da.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/de.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/el.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/en.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/es.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/fi.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/fr.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/he.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/hu.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/id.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/it.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/ja.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/ko.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/nl.json` (+2 -0) 📝 `packages/hoppscotch-common/locales/no.json` (+2 -0) _...and 12 more files_ </details> ### 📄 Description Closes #4994 The web app doesn't properly check if the email address is empty or the same. This also causes an unnecessary request to the server. I need to add checks to prevent saving empty or unchanged email addresses and avoid that extra server call. Also, includes relevant `i18n` string additions. ### What's changed Implemented validation for empty or identical emails before the API call. ### Notes to reviewers --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>