[PR #4969] [MERGED] test(backend): account for race conditions in `verifyMagicLinkTokens` test suite #5006

New issue

Closed

opened 2026-03-17 02:29:44 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:29:44 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4969
Author: @mirarifhasan
Created: 4/8/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/auth-test-case

📝 Commits (1)

5dcda05 test: verifyMagicLinkTokens test case fix

📊 Changes

1 file changed (+4 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-backend/src/auth/auth.service.spec.ts (+4 -3)

📄 Description

Closes #4964

What's changed

This PR fixes a test case for the verifyMagicLinkTokens function.
The test case was related to a timestamp issue, which is difficult to reproduce unless the test runs on a very fast machine.

Explanatiton

Most of the time when we run the tests, expiresOn becomes slightly outdated by the time and the test function passes.
Whenever you use a fast machine, expiresOn may hold the current time, which can trigger an error in subsequent functions.

Notes to reviewers

Nil

How to Test

Just run the followed cmds

cd packages/hoppscotch-backend
pnpm run test

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4969 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 4/8/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/auth-test-case` --- ### 📝 Commits (1) - [`5dcda05`](https://github.com/hoppscotch/hoppscotch/commit/5dcda0583f48105cfc252fd21a4a5cd75fc884ef) test: verifyMagicLinkTokens test case fix ### 📊 Changes **1 file changed** (+4 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/auth/auth.service.spec.ts` (+4 -3) </details> ### 📄 Description    Closes #4964  ### What's changed  This PR fixes a test case for the `verifyMagicLinkTokens` function. The test case was related to a timestamp issue, which is difficult to reproduce unless the test runs on a very fast machine. #### Explanatiton Most of the time when we run the tests, `expiresOn` becomes slightly outdated by the time and the test function passes. Whenever you use a fast machine, `expiresOn` may hold the current time, which can trigger an error in subsequent functions.  ### Notes to reviewers  Nil ### How to Test Just run the followed cmds ```cmd cd packages/hoppscotch-backend pnpm run test ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>