[PR #4939] [MERGED] fix(desktop): enable cookie support for sh-desktop #4992

Closed
opened 2026-03-17 02:28:55 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4939
Author: @CuriousCorrelation
Created: 3/26/2025
Status: Merged
Merged: 3/26/2025
Merged by: @jamesgeorge007

Base: nextHead: fix-sh-desktop-cookie-support


📝 Commits (1)

  • bd22c00 fix(desktop): enable cookie support for sh-desktop

📊 Changes

1 file changed (+2 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-selfhost-web/src/main.ts (+2 -0)

📄 Description

This PR enables cookie support for the SH Desktop App.

Before After
Before 1 After 1
Notice the missing Cookie button at the footer Button is now present

After 2
After 3

Closes HFE-796
Closes #4918

Notes for reviewers

This feature is already present and enabled on the Cloud Desktop App, see the corresponding file in the relevant repo.

For testing this out quickly without setting up AIO container, you can:

❯ cd packages/hoppscotch-selfhost-web
❯ pnpm generate && cd webapp-server && RUST_LOG=debug cargo run

This will start a temporary bundle server.
After it's up and running, use localhost:3200 as the instance URL in the "Add a new Instance" section. This will work with the currently released desktop app as well, no need to re-build it from source.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4939 **Author:** [@CuriousCorrelation](https://github.com/CuriousCorrelation) **Created:** 3/26/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix-sh-desktop-cookie-support` --- ### 📝 Commits (1) - [`bd22c00`](https://github.com/hoppscotch/hoppscotch/commit/bd22c00a5acf6563ceff545076fdfd734267027c) fix(desktop): enable cookie support for sh-desktop ### 📊 Changes **1 file changed** (+2 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-web/src/main.ts` (+2 -0) </details> ### 📄 Description This PR enables cookie support for the SH Desktop App. | Before | After | | --- | --- | | ![Before 1](https://github.com/user-attachments/assets/a02ee9de-e8bd-40fc-afa9-627a1e2577ed) | ![After 1](https://github.com/user-attachments/assets/bafd9d19-47de-43c0-b27a-8535730c7349) | | Notice the missing `Cookie` button at the footer | Button is now present | ![After 2](https://github.com/user-attachments/assets/ab384246-2439-4518-8190-0cc2bec4e030) ![After 3](https://github.com/user-attachments/assets/3bcf9b8a-6a9f-4b46-b454-d53029a25984) Closes HFE-796 Closes #4918 #### Notes for reviewers This feature is already present and enabled on the Cloud Desktop App, see the corresponding file in the relevant repo. For testing this out quickly without setting up AIO container, you can: ``` ❯ cd packages/hoppscotch-selfhost-web ❯ pnpm generate && cd webapp-server && RUST_LOG=debug cargo run ``` This will start a temporary bundle server. After it's up and running, use `localhost:3200` as the instance URL in the "Add a new Instance" section. This will work with the currently released desktop app as well, no need to re-build it from source. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:28:55 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4992
No description provided.