[PR #4910] [MERGED] fix(common): pre-process proxy response to base type #4985

Closed
opened 2026-03-17 02:28:23 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4910
Author: @CuriousCorrelation
Created: 3/19/2025
Status: Merged
Merged: 3/19/2025
Merged by: @jamesgeorge007

Base: patchHead: fix-interceptor-proxy-parse


📝 Commits (1)

  • 4e90de9 fix(common): pre-process proxy response to base type

📊 Changes

1 file changed (+4 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-common/src/platform/std/kernel-interceptors/proxy/index.ts (+4 -4)

📄 Description

This PR fixes non-json response types not being correctly decomposed to the base Uint8Array type for kernel processors.

Closes #4895
Closes HFE-785

Notes to reviewers

Try any non-json response requests API, the request will fail.

Before After
image image

Note

You may see incorrect interceptor embed after request failure on live version, it is fixed with https://github.com/hoppscotch/hoppscotch/pull/4887


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4910 **Author:** [@CuriousCorrelation](https://github.com/CuriousCorrelation) **Created:** 3/19/2025 **Status:** ✅ Merged **Merged:** 3/19/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix-interceptor-proxy-parse` --- ### 📝 Commits (1) - [`4e90de9`](https://github.com/hoppscotch/hoppscotch/commit/4e90de98cbc97cce9a2feee746e0d439c22b99c3) fix(common): pre-process proxy response to base type ### 📊 Changes **1 file changed** (+4 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/platform/std/kernel-interceptors/proxy/index.ts` (+4 -4) </details> ### 📄 Description This PR fixes non-json response types not being correctly decomposed to the base `Uint8Array` type for kernel processors. Closes #4895 Closes HFE-785 #### Notes to reviewers Try any non-json response requests API, the request will fail. | Before | After | | ------------- | ------------- | | ![image](https://github.com/user-attachments/assets/6db01f10-2295-4e36-b1cf-d57ee1cabc6d) | ![image](https://github.com/user-attachments/assets/b0142921-70f5-4abf-9bc5-5f9d4d12939b) | > [!NOTE] > You may see incorrect interceptor embed after request failure on live version, it is fixed with https://github.com/hoppscotch/hoppscotch/pull/4887 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:28:23 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4985
No description provided.