[PR #4868] [MERGED] feat(desktop): update check timeout 2s -> 5s #4967

New issue

Closed

opened 2026-03-17 02:27:34 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:27:34 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4868
Author: @CuriousCorrelation
Created: 3/10/2025
Status: ✅ Merged
Merged: 3/10/2025
Merged by: @jamesgeorge007

Base: patch ← Head: fix/desktop/fallback-timeout-after-builtin

📝 Commits (1)

c23b0e4 feat(desktop): increase updater timeout 5s

📊 Changes

1 file changed (+10 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-desktop/src/utils/updater.ts (+10 -5)

📄 Description

This PR increases timeout for checking updates, mainly for slower internet connections. In most cases the update check returns almost immediately.

It also increases the fallback promise timeout to make sure there's indeed an issue with check and not a tie or other inconsistencies in the promise race.

Notes to reviewers

You can test this out by connecting via slower network or network with major packet loss, sometimes the update check would fail and the app will continue with loading the main app.

Although even in that case it will work after a couple of restarts, so the worst case scenario is a delayed update.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4868 **Author:** [@CuriousCorrelation](https://github.com/CuriousCorrelation) **Created:** 3/10/2025 **Status:** ✅ Merged **Merged:** 3/10/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/desktop/fallback-timeout-after-builtin` --- ### 📝 Commits (1) - [`c23b0e4`](https://github.com/hoppscotch/hoppscotch/commit/c23b0e4abe0d3f6dd7d97c77d0dfd3def3119280) feat(desktop): increase updater timeout 5s ### 📊 Changes **1 file changed** (+10 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-desktop/src/utils/updater.ts` (+10 -5) </details> ### 📄 Description This PR increases timeout for checking updates, mainly for slower internet connections. In most cases the update check returns almost immediately. It also increases the fallback promise timeout to make sure there's indeed an issue with `check` and not a tie or other inconsistencies in the promise race. ### Notes to reviewers You can test this out by connecting via slower network or network with major packet loss, sometimes the update check would fail and the app will continue with loading the main app. Although even in that case it will work after a couple of restarts, so the worst case scenario is a delayed update. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>