[PR #4818] [MERGED] fix(common): improve authorization header handling #4946

New issue

Closed

opened 2026-03-17 02:26:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:26:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4818
Author: @anwarulislam
Created: 3/4/2025
Status: ✅ Merged
Merged: 3/26/2025
Merged by: @jamesgeorge007

Base: next ← Head: fix/specify-apikey-authorization

📝 Commits (2)

00aac22 fix(common): improve authorization header handling
6f13245 fix(common): added authorization header handling logic and priority rules

📊 Changes

1 file changed (+30 additions, -3 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts (+30 -3)

📄 Description

Closes HFE-769 #3956

This update simplifies the logic for handling authentication headers. It clearly specifies the conditions under which we should skip adding authorization headers: specifically, when an Authorization header is already defined by the user. This exception does not apply when we are using API-key authentication with a different header name.

Not Completed
Completed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4818 **Author:** [@anwarulislam](https://github.com/anwarulislam) **Created:** 3/4/2025 **Status:** ✅ Merged **Merged:** 3/26/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/specify-apikey-authorization` --- ### 📝 Commits (2) - [`00aac22`](https://github.com/hoppscotch/hoppscotch/commit/00aac224d6ee2492e0dc33982cbb95d2e00848b5) fix(common): improve authorization header handling - [`6f13245`](https://github.com/hoppscotch/hoppscotch/commit/6f1324590f9985addbb5f17c828911bd02989ee9) fix(common): added authorization header handling logic and priority rules ### 📊 Changes **1 file changed** (+30 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts` (+30 -3) </details> ### 📄 Description Closes HFE-769 #3956 This update simplifies the logic for handling authentication headers. It clearly specifies the conditions under which we should skip adding authorization headers: specifically, when an Authorization header is already defined by the user. This exception does not apply when we are using API-key authentication with a different header name. - [ ] Not Completed - [x] Completed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>