[PR #4775] [MERGED] chore: openapi importer bug fixs #4929

Closed
opened 2026-03-17 02:25:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4775
Author: @amk-dev
Created: 2/20/2025
Status: Merged
Merged: 2/24/2025
Merged by: @jamesgeorge007

Base: nextHead: chore/openapi-improvements


📝 Commits (4)

  • 731587a chore: run url requests via interceptor + circular ref handling
  • 45e440a chore: bump swagger-parser
  • d26fd00 fix: body being undefined
  • 0cdf80e chore: cleanup

📊 Changes

5 files changed (+81 additions, -18 deletions)

View changed files

📝 packages/hoppscotch-common/package.json (+1 -1)
📝 packages/hoppscotch-common/src/components/importExport/ImportExportSteps/UrlImport.vue (+33 -13)
📝 packages/hoppscotch-common/src/helpers/import-export/import/import-sources/GistSource.ts (+29 -3)
📝 packages/hoppscotch-common/src/helpers/import-export/import/openapi.ts (+14 -1)
📝 packages/hoppscotch-common/src/services/interceptor.service.ts (+4 -0)

📄 Description

This PR makes some bug fixs to the Openapi importer

  • Route url imports via interceptor ( some users reported cors issues, this should give them a way to bypass cors )
  • Ignore circular references in the response body ( there's a existing bug related to this, see HFE-765 ). Ideally in the example response, there shouldnt be any circular references. previously this was throwing and casing the entire import to fail. Now we just ignore the circular references and continue the import.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4775 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 2/20/2025 **Status:** ✅ Merged **Merged:** 2/24/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `chore/openapi-improvements` --- ### 📝 Commits (4) - [`731587a`](https://github.com/hoppscotch/hoppscotch/commit/731587a7d439cec2716f89b1e8fb75a02fb347cb) chore: run url requests via interceptor + circular ref handling - [`45e440a`](https://github.com/hoppscotch/hoppscotch/commit/45e440aa3946d15debcdb3d1da242f0d1af46302) chore: bump swagger-parser - [`d26fd00`](https://github.com/hoppscotch/hoppscotch/commit/d26fd00b9fc540257a9f9855914e8f78a9cda3a8) fix: body being undefined - [`0cdf80e`](https://github.com/hoppscotch/hoppscotch/commit/0cdf80e378ba15c6687ef5b065a9f3f89e1cb591) chore: cleanup ### 📊 Changes **5 files changed** (+81 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/package.json` (+1 -1) 📝 `packages/hoppscotch-common/src/components/importExport/ImportExportSteps/UrlImport.vue` (+33 -13) 📝 `packages/hoppscotch-common/src/helpers/import-export/import/import-sources/GistSource.ts` (+29 -3) 📝 `packages/hoppscotch-common/src/helpers/import-export/import/openapi.ts` (+14 -1) 📝 `packages/hoppscotch-common/src/services/interceptor.service.ts` (+4 -0) </details> ### 📄 Description This PR makes some bug fixs to the Openapi importer - Route url imports via interceptor ( some users reported cors issues, this should give them a way to bypass cors ) - Ignore circular references in the response body ( there's a existing bug related to this, see [HFE-765](https://linear.app/hoppscotch/issue/HFE-765/openapi-import-with-responses-are-importing-schema-instead-of-examples) ). Ideally in the example response, there shouldnt be any circular references. previously this was throwing and casing the entire import to fail. Now we just ignore the circular references and continue the import. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:25:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4929
No description provided.