[PR #4755] [CLOSED] fix: ensure duplicated headers are mapped to response #4920

New issue

Closed

opened 2026-03-17 02:24:40 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:24:40 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4755
Author: @thiagocavalcanti
Created: 2/14/2025
Status: ❌ Closed

Base: patch ← Head: fix/http-headers-duplicated

📝 Commits (1)

3473520 fix: ensure duplicated headers are mapped to response

📊 Changes

1 file changed (+7 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/network.ts (+7 -4)

📄 Description

When a NetworkResponse has multiple headers with the same key, the old code only retrieved the first header with that key. This is a classic scenario for the set-cookie header, where multiple cookies are often sent.

What's changed

Handle NetworkResponse.headers values as possible string[]

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4755 **Author:** [@thiagocavalcanti](https://github.com/thiagocavalcanti) **Created:** 2/14/2025 **Status:** ❌ Closed **Base:** `patch` ← **Head:** `fix/http-headers-duplicated` --- ### 📝 Commits (1) - [`3473520`](https://github.com/hoppscotch/hoppscotch/commit/34735206d6cf4f4d61884ef0ebeaf5359cdfc9c5) fix: ensure duplicated headers are mapped to response ### 📊 Changes **1 file changed** (+7 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/network.ts` (+7 -4) </details> ### 📄 Description   Related to https://github.com/hoppscotch/hoppscotch/issues/3532#issuecomment-1983491480 When a NetworkResponse has multiple headers with the same key, the old code only retrieved the first header with that key. This is a classic scenario for the set-cookie header, where multiple cookies are often sent.  ### What's changed   - Handle NetworkResponse.headers values as possible string[] --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>