[PR #4712] [MERGED] fix: ensure correct body for application/x-www-form-urlencoded in all code exports #4915

Closed
opened 2026-03-17 02:24:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4712
Author: @shuaixr
Created: 1/31/2025
Status: Merged
Merged: 2/6/2025
Merged by: @jamesgeorge007

Base: patchHead: fix/export-urlencoded-body


📝 Commits (1)

  • 1233fd2 fix: ensure correct body for application/x-www-form-urlencoded in all code exports

📊 Changes

1 file changed (+4 additions, -0 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts (+4 -0)

📄 Description

Closes #4690

What's changed

github.com/hoppscotch/hoppscotch@e967b3361d/packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts (L431-L475) if body.contentType is application/x-www-form-urlencoded, the processed body is empty string, so I fixed it.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4712 **Author:** [@shuaixr](https://github.com/shuaixr) **Created:** 1/31/2025 **Status:** ✅ Merged **Merged:** 2/6/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/export-urlencoded-body` --- ### 📝 Commits (1) - [`1233fd2`](https://github.com/hoppscotch/hoppscotch/commit/1233fd269c89c08776d699b7ca1ef1370be90401) fix: ensure correct body for application/x-www-form-urlencoded in all code exports ### 📊 Changes **1 file changed** (+4 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts` (+4 -0) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #4690 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed https://github.com/hoppscotch/hoppscotch/blob/e967b3361d0fba3d2b6648af65509bbc1f49aa69/packages/hoppscotch-common/src/helpers/utils/EffectiveURL.ts#L431-L475 if `body.contentType` is `application/x-www-form-urlencoded`, the processed body is empty string, so I fixed it. <!-- Describe point by point the different things you have changed in this PR --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:24:24 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4915
No description provided.