[PR #4642] [MERGED] feat(sh-admin): introducing input validations to server configurations in admin dashboard #4886

New issue

Closed

opened 2026-03-17 02:23:02 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:23:02 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4642
Author: @joeljstephen
Created: 12/24/2024
Status: ✅ Merged
Merged: 2/19/2025
Merged by: @jamesgeorge007

Base: next ← Head: refactor/dashboard-input-validation

📝 Commits (5)

5b5a1d1 feat: introduced a new global state to handle input validation in configs
0e48162 refactor: moved hasInputValidationFailed to configs helper file
190172c chore: replaced strings with i18n counterparts
d1eb59a fix: deletion fixes for user and workspace table
a709b55 chore: cleanup

📊 Changes

7 files changed (+68 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/locales/en.json (+2 -0)
📝 packages/hoppscotch-sh-admin/src/components.d.ts (+2 -0)
📝 packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue (+35 -2)
📝 packages/hoppscotch-sh-admin/src/helpers/configs.ts (+4 -0)
📝 packages/hoppscotch-sh-admin/src/pages/settings.vue (+13 -1)
📝 packages/hoppscotch-sh-admin/src/pages/teams/index.vue (+6 -1)
📝 packages/hoppscotch-sh-admin/src/pages/users/index.vue (+6 -1)

📄 Description

Ticket

Closes HFE-711

Description

This PR focuses adding a simple system to add input validation to input fields in server configurations in the admin dashboard. Input validation is added to MAILER_SMTP_URL field where the field should start with smtp(s)://. Additionally, the PR includes minor fixes related to deletion in the user and workspace tables.

Screenshot

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed…figs

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4642 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/24/2024 **Status:** ✅ Merged **Merged:** 2/19/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `refactor/dashboard-input-validation` --- ### 📝 Commits (5) - [`5b5a1d1`](https://github.com/hoppscotch/hoppscotch/commit/5b5a1d16cbdb28fbefcecf0e6115f93ac5dde7bf) feat: introduced a new global state to handle input validation in configs - [`0e48162`](https://github.com/hoppscotch/hoppscotch/commit/0e48162bd9c918881433367c0a4510ef87cbcffc) refactor: moved hasInputValidationFailed to configs helper file - [`190172c`](https://github.com/hoppscotch/hoppscotch/commit/190172cb4bec207b48393c6fcdf323141c19d4dc) chore: replaced strings with i18n counterparts - [`d1eb59a`](https://github.com/hoppscotch/hoppscotch/commit/d1eb59a346f2fd56fac5af8567050155e941c5bd) fix: deletion fixes for user and workspace table - [`a709b55`](https://github.com/hoppscotch/hoppscotch/commit/a709b5583a01ce971b44b8051eb160c9ed430522) chore: cleanup ### 📊 Changes **7 files changed** (+68 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/locales/en.json` (+2 -0) 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+2 -0) 📝 `packages/hoppscotch-sh-admin/src/components/settings/SmtpConfiguration.vue` (+35 -2) 📝 `packages/hoppscotch-sh-admin/src/helpers/configs.ts` (+4 -0) 📝 `packages/hoppscotch-sh-admin/src/pages/settings.vue` (+13 -1) 📝 `packages/hoppscotch-sh-admin/src/pages/teams/index.vue` (+6 -1) 📝 `packages/hoppscotch-sh-admin/src/pages/users/index.vue` (+6 -1) </details> ### 📄 Description ### Ticket - Closes HFE-711 ### Description This PR focuses adding a simple system to add input validation to input fields in server configurations in the admin dashboard. Input validation is added to `MAILER_SMTP_URL` field where the field should start with `smtp(s)://`. Additionally, the PR includes minor fixes related to deletion in the user and workspace tables. ### Screenshot ![image](https://github.com/user-attachments/assets/708917a1-f04f-4245-947a-ac9528eb0ad8) ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed…figs --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>