[PR #4624] [MERGED] fix(sh-admin): resolve record retrieval limits in pending invites section by implementing pagination #4877

New issue

Closed

opened 2026-03-17 02:22:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:22:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4624
Author: @joeljstephen
Created: 12/17/2024
Status: ✅ Merged
Merged: 12/19/2024
Merged by: @jamesgeorge007

Base: next ← Head: fix/dashboard-invites-pagination

📝 Commits (3)

fd55e3c fix: updated pending invites to use pagination
a5fdb5e chore: better variable naming and removed unnecessary logic
0c27c5c chore: better logic structuring

📊 Changes

3 files changed (+59 additions, -19 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/src/components.d.ts (+1 -0)
📝 packages/hoppscotch-sh-admin/src/helpers/backend/gql/queries/InvitedUsers.graphql (+2 -2)
📝 packages/hoppscotch-sh-admin/src/pages/users/invited.vue (+56 -17)

📄 Description

Ticket

Closes HFE-694

Description

This PR resolves an issue where the Pending Invites page under the Users section in the Admin Dashboard was only fetching 10 records. The root cause was identified in how the frontend called the relevant query, which defaults to returning a maximum of 10 records unless specified otherwise.
To address this, pagination support is added where the frontend query now explicitly requests the desired number of records and includes additional parameters to enable fetching more data when required. This ensures that the correct number of records is displayed.

Fix Summary:

Updated the frontend query to specify the required record count.
Added pagination support for Pending Invites.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4624 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 12/17/2024 **Status:** ✅ Merged **Merged:** 12/19/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/dashboard-invites-pagination` --- ### 📝 Commits (3) - [`fd55e3c`](https://github.com/hoppscotch/hoppscotch/commit/fd55e3c55ec3fc80563314ce310b0f1d02246e35) fix: updated pending invites to use pagination - [`a5fdb5e`](https://github.com/hoppscotch/hoppscotch/commit/a5fdb5e2cb2eb551e0fc3da9dd8491601a0067c5) chore: better variable naming and removed unnecessary logic - [`0c27c5c`](https://github.com/hoppscotch/hoppscotch/commit/0c27c5c781402cf02ceb7e352e38436dbe30ecb0) chore: better logic structuring ### 📊 Changes **3 files changed** (+59 additions, -19 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+1 -0) 📝 `packages/hoppscotch-sh-admin/src/helpers/backend/gql/queries/InvitedUsers.graphql` (+2 -2) 📝 `packages/hoppscotch-sh-admin/src/pages/users/invited.vue` (+56 -17) </details> ### 📄 Description ### Ticket - Closes HFE-694 ### Description This PR resolves an issue where the Pending Invites page under the Users section in the Admin Dashboard was only fetching 10 records. The root cause was identified in how the frontend called the relevant query, which defaults to returning a maximum of 10 records unless specified otherwise. To address this, pagination support is added where the frontend query now explicitly requests the desired number of records and includes additional parameters to enable fetching more data when required. This ensures that the correct number of records is displayed. ### Fix Summary: - Updated the frontend query to specify the required record count. - Added pagination support for Pending Invites. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>