[PR #4595] [MERGED] chore: improve healthcheck configuration for AIO container #4865

Closed
opened 2026-03-17 02:21:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4595
Author: @progprnv
Created: 12/5/2024
Status: Merged
Merged: 5/14/2025
Merged by: @jamesgeorge007

Base: nextHead: patch-1


📝 Commits (2)

  • ee14b74 Improved code for health check - Update docker-compose.deploy.yml
  • 8d5ab0b chore: format applied

📊 Changes

2 files changed (+29 additions, -9 deletions)

View changed files

📝 docker-compose.deploy.yml (+19 -8)
📝 docker-compose.yml (+10 -1)

📄 Description

The current health check block doesn't check for errors or exceptions that might occur during the request.

Here is the modified code for a 'precise health check' :

healthcheck:
test: [ "CMD", "curl", "-f", "-s", "-o", "/dev/null", "-w", "%{http_code}", "http://localhost:80" ]
interval: 2s
timeout: 10s
retries: 30

Closes #

What's changed

Notes to reviewers


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4595 **Author:** [@progprnv](https://github.com/progprnv) **Created:** 12/5/2024 **Status:** ✅ Merged **Merged:** 5/14/2025 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `patch-1` --- ### 📝 Commits (2) - [`ee14b74`](https://github.com/hoppscotch/hoppscotch/commit/ee14b74d194e88a3767f0ac4a63cd11f8243ed7b) Improved code for health check - Update docker-compose.deploy.yml - [`8d5ab0b`](https://github.com/hoppscotch/hoppscotch/commit/8d5ab0bbd112d8854d849ae47ae5de88ac4ec1ae) chore: format applied ### 📊 Changes **2 files changed** (+29 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `docker-compose.deploy.yml` (+19 -8) 📝 `docker-compose.yml` (+10 -1) </details> ### 📄 Description The current health check block doesn't check for errors or exceptions that might occur during the request. Here is the modified code for a 'precise health check' : healthcheck: test: [ "CMD", "curl", "-f", "-s", "-o", "/dev/null", "-w", "%{http_code}", "http://localhost:80" ] interval: 2s timeout: 10s retries: 30 <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes # <!-- Issue # here --> <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Notes to reviewers <!-- Any information you feel the reviewer should know about when reviewing your PR --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:21:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4865
No description provided.