[PR #4571] fix: parse json object before sending it through socket #4860

Open
opened 2026-03-17 02:21:24 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4571
Author: @Tlepel
Created: 11/28/2024
Status: 🔄 Open

Base: mainHead: socketio-emit-objects-properly


📝 Commits (1)

  • 6003d2e fix: parse json object before sending it through socket

📊 Changes

1 file changed (+13 additions, -5 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/realtime/Communication.vue (+13 -5)

📄 Description

fix #4570

Closes #4570

What's changed

This MR makes sure any JSON data that is sent with realtime communication is actually sent the way the network expects the messages

Notes to reviewers


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4571 **Author:** [@Tlepel](https://github.com/Tlepel) **Created:** 11/28/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `socketio-emit-objects-properly` --- ### 📝 Commits (1) - [`6003d2e`](https://github.com/hoppscotch/hoppscotch/commit/6003d2ef7c9d13f86acda83a361dca65d5aac5aa) fix: parse json object before sending it through socket ### 📊 Changes **1 file changed** (+13 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/realtime/Communication.vue` (+13 -5) </details> ### 📄 Description fix #4570 <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #4570 <!-- Issue # here --> <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> This MR makes sure any JSON data that is sent with realtime communication is actually sent the way the network expects the messages <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Notes to reviewers <!-- Any information you feel the reviewer should know about when reviewing your PR --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4860
No description provided.