mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4545] [MERGED] HSB-499 feat: env file sync with infra config #4850
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4850
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4545
Author: @mirarifhasan
Created: 11/18/2024
Status: ✅ Merged
Merged: 11/26/2024
Merged by: @jamesgeorge007
Base:
next← Head:feat/infra-config-sync-env-file📝 Commits (10+)
446f6f6feat: env file sync with infra config78cf69ctest: fix type error on infra-config unit test162e6b3test: fix timestamp broken unit test of shortcode modulec720c89fix: isEncrypted check added on storing in db71e4af1fix: modify env old env data check logicc540179feat: env file null incoming value support addedfc0393dchore: handle edge case if SSO secret and VITE_ALLOWED update together from .envfe5da3dchore: infra-config fix itself in runtime if SSO variables not configured16ccdb4fix: edge case resolve if only email auth provider present with custom config falsedb770c3chore: error message added if DATA_ENCRYPTION_KEY change from .env file📊 Changes
8 files changed (+210 additions, -59 deletions)
View changed files
➕
packages/hoppscotch-backend/prisma/migrations/20241118054346_infra_config_sync_with_env_file/migration.sql(+3 -0)📝
packages/hoppscotch-backend/prisma/schema.prisma(+7 -7)📝
packages/hoppscotch-backend/src/auth/auth.module.ts(+3 -3)📝
packages/hoppscotch-backend/src/errors.ts(+6 -0)📝
packages/hoppscotch-backend/src/infra-config/helper.ts(+155 -36)📝
packages/hoppscotch-backend/src/infra-config/infra-config.service.spec.ts(+6 -6)📝
packages/hoppscotch-backend/src/infra-config/infra-config.service.ts(+24 -3)📝
packages/hoppscotch-backend/src/shortcode/shortcode.service.spec.ts(+6 -4)📄 Description
Closes HSB-499
What's changed
This PR adds synchronization if
.envchanges later on.With these benefits, the end user can change any variables (i.e. SSO Secrets, ClickHouse configs, etc) either from Admin Dashboard or
.envfile, both will be synced and take the latest updates' value.Notes to reviewers
Nil
Documentation updates
We can remove this Hard reset Configuration Docs
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.