[PR #4516] [MERGED] fix: clicking on run query without connecting connects without docs polling #4842

New issue

Closed

opened 2026-03-17 02:20:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:20:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4516
Author: @AndrewBastin
Created: 11/6/2024
Status: ✅ Merged
Merged: 11/7/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/gql-connect-without-docs

📝 Commits (1)

3b8dcd2 fix: clicking on run query without connecting connects without docs updates

📊 Changes

2 files changed (+8 additions, -7 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+1 -1)
📝 packages/hoppscotch-common/src/helpers/graphql/connection.ts (+7 -6)

📄 Description

This PR introduces a fix for an issue where when running GraphQL requests without clicking on query, the connect button changes into Disconnect without doing a formal connection and pulling docs and starting polling.

What's changed

GQL connect function is now async and waits for the first poll to be done before resolving
runGQLOperation calls and waits on connect before executing the operation.

Notes to reviewers

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4516 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 11/6/2024 **Status:** ✅ Merged **Merged:** 11/7/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/gql-connect-without-docs` --- ### 📝 Commits (1) - [`3b8dcd2`](https://github.com/hoppscotch/hoppscotch/commit/3b8dcd25143298a0da74bef912d147bfbe8da829) fix: clicking on run query without connecting connects without docs updates ### 📊 Changes **2 files changed** (+8 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+1 -1) 📝 `packages/hoppscotch-common/src/helpers/graphql/connection.ts` (+7 -6) </details> ### 📄 Description This PR introduces a fix for an issue where when running GraphQL requests without clicking on query, the connect button changes into `Disconnect` without doing a formal connection and pulling docs and starting polling. ### What's changed - GQL `connect` function is now async and waits for the first poll to be done before resolving - `runGQLOperation` calls and waits on `connect` before executing the operation. ### Notes to reviewers  --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>