[PR #4535] [MERGED] chore: continue openapi imports on error with a partial import #4841

Closed
opened 2026-03-17 02:20:35 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4535
Author: @amk-dev
Created: 11/13/2024
Status: Merged
Merged: 11/25/2024
Merged by: @jamesgeorge007

Base: nextHead: fix/continue-import-on-error-openapi


📝 Commits (2)

  • 34e8e21 fix: continue parsing openapi doc instead of failing
  • 668027d fix: add a very basic validation for openapi docs

📊 Changes

1 file changed (+69 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/helpers/import-export/import/openapi.ts (+69 -2)

📄 Description

Fixs HFE-659

Before

If validating an openapi failed, we abort the entire import and shows an error message.

After

If the validation failed, but there's a schema available with the error, we import that instead of entirely breaking the import


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4535 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 11/13/2024 **Status:** ✅ Merged **Merged:** 11/25/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/continue-import-on-error-openapi` --- ### 📝 Commits (2) - [`34e8e21`](https://github.com/hoppscotch/hoppscotch/commit/34e8e218d76bd1514aa82bd011a5138d1edcbcb1) fix: continue parsing openapi doc instead of failing - [`668027d`](https://github.com/hoppscotch/hoppscotch/commit/668027d48baf8bd3d468cb368bbaaefc5128b2c8) fix: add a very basic validation for openapi docs ### 📊 Changes **1 file changed** (+69 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/helpers/import-export/import/openapi.ts` (+69 -2) </details> ### 📄 Description Fixs HFE-659 **Before** If validating an openapi failed, we abort the entire import and shows an error message. **After** If the validation failed, but there's a schema available with the error, we import that instead of entirely breaking the import --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:20:35 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4841
No description provided.