[PR #4514] [MERGED] fix: correct broken codemirror-lang-graphql in node 22 #4838

New issue

Closed

opened 2026-03-17 02:20:19 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:20:19 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4514
Author: @AndrewBastin
Created: 11/5/2024
Status: ✅ Merged
Merged: 11/5/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/node-22-issues

📝 Commits (1)

c6e36dd fix: correct broken codemirror-lang-graphql in node 22

📊 Changes

4 files changed (+75 additions, -291 deletions)

View changed files

📝 packages/codemirror-lang-graphql/package.json (+3 -4)
📝 packages/codemirror-lang-graphql/rollup.config.js (+7 -2)
📝 packages/codemirror-lang-graphql/tsconfig.json (+1 -0)
📝 pnpm-lock.yaml (+64 -285)

📄 Description

This PR intends to fix the issues with building codemirror-lang-graphql in Node 22.

The issue is caused by Node 22 dropping the assert keyword for import assertions. We use rollup-plugin-ts as the plugin to parse typescript files, which uses assert keyword inside it.

What's changed

Move to @rollup/plugin-typescript and remove rollup-plugin-ts and rollup-plugin-dts.
Update prepare script to also generate declaration file for codemirror-lang-graphql package.

Notes to reviewers

Do make sure the GraphQL syntax highlighting still works and is stable across SH, Web and Desktop across debug and production modes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4514 **Author:** [@AndrewBastin](https://github.com/AndrewBastin) **Created:** 11/5/2024 **Status:** ✅ Merged **Merged:** 11/5/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/node-22-issues` --- ### 📝 Commits (1) - [`c6e36dd`](https://github.com/hoppscotch/hoppscotch/commit/c6e36dd94f00af85230e869df34b1df64e7966b4) fix: correct broken codemirror-lang-graphql in node 22 ### 📊 Changes **4 files changed** (+75 additions, -291 deletions) <details> <summary>View changed files</summary> 📝 `packages/codemirror-lang-graphql/package.json` (+3 -4) 📝 `packages/codemirror-lang-graphql/rollup.config.js` (+7 -2) 📝 `packages/codemirror-lang-graphql/tsconfig.json` (+1 -0) 📝 `pnpm-lock.yaml` (+64 -285) </details> ### 📄 Description This PR intends to fix the issues with building `codemirror-lang-graphql` in Node 22. The issue is caused by Node 22 dropping the `assert` keyword for import assertions. We use `rollup-plugin-ts` as the plugin to parse typescript files, which uses `assert` keyword inside it. ### What's changed - Move to `@rollup/plugin-typescript` and remove `rollup-plugin-ts` and `rollup-plugin-dts`. - Update prepare script to also generate declaration file for `codemirror-lang-graphql` package. ### Notes to reviewers Do make sure the GraphQL syntax highlighting still works and is stable across SH, Web and Desktop across debug and production modes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>