[PR #4464] [MERGED] chore: environment highlight colour schema update #4812

New issue

Closed

opened 2026-03-17 02:18:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:18:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4464
Author: @nivedin
Created: 10/22/2024
Status: ✅ Merged
Merged: 10/25/2024
Merged by: @jamesgeorge007

Base: next ← Head: fix/variable-colour-schema-update

📝 Commits (10+)

398e3f3 chore: env highlight colour schema update
47d3bfa chore: make selectionMatch color visible
649374f chore: add filter for commented predefined vars
ec51329 chore: add cm-comment class name to cm-base theme comments
181dad0 chore: remove hopp-comment plugin
97dac46 fix: update comment colour
8762286 chore: revert cm-comment highlight style
ef4c13c chore: stop highlight and tooltip if inside a comment
6220405 chore: minor change
5e191c9 chore: extend to raw key value pair syntax

📊 Changes

6 files changed (+88 additions, -29 deletions)

View changed files

📝 packages/hoppscotch-common/assets/scss/styles.scss (+29 -16)
📝 packages/hoppscotch-common/src/components.d.ts (+2 -0)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts (+25 -10)
📝 packages/hoppscotch-common/src/helpers/editor/extensions/HoppPredefinedVariables.ts (+14 -2)
➕ packages/hoppscotch-common/src/helpers/editor/extensions/helpers.ts (+14 -0)
📝 packages/hoppscotch-common/src/helpers/editor/themes/baseTheme.ts (+4 -1)

📄 Description

Closes HFE-605 #4389

Before

After

This PR improves the colors on variables for multiple themes and improve contrast on codemirror.

What's changed

The text colour inside the env variable have been set to white and the syntax highlight has been removed from the env variable for commented line.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4464 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 10/22/2024 **Status:** ✅ Merged **Merged:** 10/25/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/variable-colour-schema-update` --- ### 📝 Commits (10+) - [`398e3f3`](https://github.com/hoppscotch/hoppscotch/commit/398e3f36e7fb6f15318a613f84ff3866e9655323) chore: env highlight colour schema update - [`47d3bfa`](https://github.com/hoppscotch/hoppscotch/commit/47d3bfad82f55d6369b15f1b712e7207baca477f) chore: make selectionMatch color visible - [`649374f`](https://github.com/hoppscotch/hoppscotch/commit/649374fe14cbf5b712b3ac1cecf2d45ef9a7dd1e) chore: add filter for commented predefined vars - [`ec51329`](https://github.com/hoppscotch/hoppscotch/commit/ec513294cba4cfab983e4f8c107d26cf8ff3674d) chore: add `cm-comment` class name to cm-base theme comments - [`181dad0`](https://github.com/hoppscotch/hoppscotch/commit/181dad0d6563bb39981188dbb1e0f02feab00816) chore: remove hopp-comment plugin - [`97dac46`](https://github.com/hoppscotch/hoppscotch/commit/97dac462324167d8909dc77fb511d06f8a6ca520) fix: update comment colour - [`8762286`](https://github.com/hoppscotch/hoppscotch/commit/8762286092ed8219f283432142dd1d4e51526b05) chore: revert `cm-comment` highlight style - [`ef4c13c`](https://github.com/hoppscotch/hoppscotch/commit/ef4c13c6cbbc16b69ead98de7042cf2ffda86096) chore: stop highlight and tooltip if inside a comment - [`6220405`](https://github.com/hoppscotch/hoppscotch/commit/622040584ee6d868f231220da77af4ba3b6b945d) chore: minor change - [`5e191c9`](https://github.com/hoppscotch/hoppscotch/commit/5e191c982edb24eee0fe6f051cb3efbd61a4344b) chore: extend to raw key value pair syntax ### 📊 Changes **6 files changed** (+88 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/assets/scss/styles.scss` (+29 -16) 📝 `packages/hoppscotch-common/src/components.d.ts` (+2 -0) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppEnvironment.ts` (+25 -10) 📝 `packages/hoppscotch-common/src/helpers/editor/extensions/HoppPredefinedVariables.ts` (+14 -2) ➕ `packages/hoppscotch-common/src/helpers/editor/extensions/helpers.ts` (+14 -0) 📝 `packages/hoppscotch-common/src/helpers/editor/themes/baseTheme.ts` (+4 -1) </details> ### 📄 Description   Closes HFE-605 #4389 ### Before ![image](https://github.com/user-attachments/assets/d3a80bc8-ac34-4f2a-9c1d-8131a5187299) ### After <img width="677" alt="image" src="https://github.com/user-attachments/assets/4e21986d-97c3-45cd-a1a5-8c98c4890b68">  This PR improves the colors on variables for multiple themes and improve contrast on codemirror. ### What's changed The text colour inside the env variable have been set to white and the syntax highlight has been removed from the env variable for commented line. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>