[PR #4456] [MERGED] fix: resolve empty state image correctly in profile page #4809

New issue

Closed

opened 2026-03-17 02:18:41 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:18:41 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4456
Author: @jamesgeorge007
Created: 10/18/2024
Status: ✅ Merged
Merged: 10/22/2024
Merged by: @jamesgeorge007

Base: next ← Head: fix/pat-empty-state-image

📝 Commits (1)

0fe2370 fix: resolve empty state image correctly in profile page

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/accessTokens/List.vue (+1 -1)

📄 Description

Description

This PR aims to fix a broken reference to an image as part of the Personal Access Tokens view empty state on the profile page. Follow up of #4304.

Closes HFE-629.

What's changed

colorMode as consumed from the useColorMode() composable is a reactive object, hence, inferring the current Background selection via the value field.

github.com/hoppscotch/hoppscotch@9da5f63e70/packages/hoppscotch-common/src/modules/theming.ts (L54-L60)

github.com/hoppscotch/hoppscotch@9da5f63e70/packages/hoppscotch-common/src/composables/theming.ts (L1-L4)

Preview

Before

After

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4456 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 10/18/2024 **Status:** ✅ Merged **Merged:** 10/22/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `next` ← **Head:** `fix/pat-empty-state-image` --- ### 📝 Commits (1) - [`0fe2370`](https://github.com/hoppscotch/hoppscotch/commit/0fe2370a324b4e8fa58f2b113ccd936b2a0ae098) fix: resolve empty state image correctly in profile page ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/accessTokens/List.vue` (+1 -1) </details> ### 📄 Description ### Description This PR aims to fix a broken reference to an image as part of the `Personal Access Tokens` view empty state on the profile page. Follow up of #4304. Closes HFE-629. ### What's changed `colorMode` as consumed from the `useColorMode()` composable is a `reactive` object, hence, inferring the current `Background` selection via the `value` field. https://github.com/hoppscotch/hoppscotch/blob/9da5f63e701ba072ea393e68847d7f8e395d4c4a/packages/hoppscotch-common/src/modules/theming.ts#L54-L60 https://github.com/hoppscotch/hoppscotch/blob/9da5f63e701ba072ea393e68847d7f8e395d4c4a/packages/hoppscotch-common/src/composables/theming.ts#L1-L4 ### Preview #### Before ![image](https://github.com/user-attachments/assets/15105c43-1aa7-4f68-92ca-cebf70a8719e) #### After ![image](https://github.com/user-attachments/assets/ed41d30d-a8d8-4ba3-9d1a-7c994b87dcfc) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>