[PR #4429] [MERGED] fix(sh-admin): resolve i18n strings correctly on error toast with remove member action #4794

New issue

Closed

opened 2026-03-17 02:17:51 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:17:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4429
Author: @joeljstephen
Created: 10/11/2024
Status: ✅ Merged
Merged: 10/11/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/sh-admin-i18n-issue

📝 Commits (1)

2712f1f fix: i18n issue resolved where compiled error message not wrapped by t

📊 Changes

2 files changed (+55 additions, -59 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/src/components.d.ts (+54 -58)
📝 packages/hoppscotch-sh-admin/src/components/teams/Members.vue (+1 -1)

📄 Description

Ticket

Closes HFE-618

Description

This PR fixes an issue where the i18n string is not rendered correctly in the workspace member component associated with the remove member action from a workspace.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4429 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 10/11/2024 **Status:** ✅ Merged **Merged:** 10/11/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/sh-admin-i18n-issue` --- ### 📝 Commits (1) - [`2712f1f`](https://github.com/hoppscotch/hoppscotch/commit/2712f1f8bed7c7117b3da598581eaf89a7a8c5d2) fix: i18n issue resolved where compiled error message not wrapped by t ### 📊 Changes **2 files changed** (+55 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+54 -58) 📝 `packages/hoppscotch-sh-admin/src/components/teams/Members.vue` (+1 -1) </details> ### 📄 Description ### Ticket - Closes HFE-618 ### Description This PR fixes an issue where the i18n string is not rendered correctly in the workspace member component associated with the remove member action from a workspace. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>