[PR #4340] [MERGED] fix: preserve description while toggling field enabled status #4761

New issue

Closed

opened 2026-03-17 02:16:13 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:16:13 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4340
Author: @jcgurango
Created: 9/11/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/key-value-description

📝 Commits (2)

5c954cf Fix description getting removed on turn on/off
30c848a chore: enforce strict types

📊 Changes

1 file changed (+14 additions, -2 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/KeyValue.vue (+14 -2)

📄 Description

When turning a query parameter/header or header on/off, the Description field gets cleared.

What's changed

Account for the description field value while toggling the field enabled status by supplying it alongside the updateEntity() function call.
Enforce stricter types.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4340 **Author:** [@jcgurango](https://github.com/jcgurango) **Created:** 9/11/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/key-value-description` --- ### 📝 Commits (2) - [`5c954cf`](https://github.com/hoppscotch/hoppscotch/commit/5c954cfb48a782b5873bd3423d7026882ea2bc43) Fix description getting removed on turn on/off - [`30c848a`](https://github.com/hoppscotch/hoppscotch/commit/30c848ab8509467aa78896a87242e0ec52ea4664) chore: enforce strict types ### 📊 Changes **1 file changed** (+14 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/KeyValue.vue` (+14 -2) </details> ### 📄 Description When turning a query parameter/header or header on/off, the `Description` field gets cleared. ### What's changed - Account for the `description` field value while toggling the field enabled status by supplying it alongside the `updateEntity()` function call. - Enforce stricter types. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>