[PR #4337] [MERGED] fix: close context menu when no text is selected #4760

New issue

Closed

opened 2026-03-17 02:15:57 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:15:57 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4337
Author: @nivedin
Created: 9/10/2024
Status: ✅ Merged
Merged: 9/11/2024
Merged by: @AndrewBastin

Base: patch ← Head: fix/context-menu-bug

📝 Commits (2)

ebc181e chore: close context menu while pressing keys
4aa7120 chore: remove console statement

📊 Changes

1 file changed (+18 additions, -8 deletions)

View changed files

📝 packages/hoppscotch-common/src/composables/codemirror.ts (+18 -8)

📄 Description

Closes #4327 HFE-577

This PR fixes the issue wherewith context menu where it fails to close while there is a key press and no text selection is present.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4337 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 9/10/2024 **Status:** ✅ Merged **Merged:** 9/11/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `patch` ← **Head:** `fix/context-menu-bug` --- ### 📝 Commits (2) - [`ebc181e`](https://github.com/hoppscotch/hoppscotch/commit/ebc181e393928c1b8699df6d9652b3257162a5f3) chore: close context menu while pressing keys - [`4aa7120`](https://github.com/hoppscotch/hoppscotch/commit/4aa7120fe37013407b7a9554e311bc773a09ace9) chore: remove console statement ### 📊 Changes **1 file changed** (+18 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/composables/codemirror.ts` (+18 -8) </details> ### 📄 Description Closes #4327 HFE-577 This PR fixes the issue wherewith context menu where it fails to close while there is a key press and no text selection is present. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>