[PR #4309] [MERGED] fix: resolve multiple UI issues and account for `description` field in syncing context #4746

New issue

Closed

opened 2026-03-17 02:15:23 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:15:23 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4309
Author: @nivedin
Created: 8/29/2024
Status: ✅ Merged
Merged: 8/30/2024
Merged by: @nivedin

Base: next ← Head: fix/collection-header-properties-bulk-editor-bug

📝 Commits (6)

01c6ff6 fix: collection properties header bulk update editor bug
0d1bb06 chore: add migration step while resolving headers in the syncing context
5a38f4e fix: prevent inifinite loading state in add environments modal
fae54fb fix: tab change when clicking computed auth
e6a4f48 fix: ensure tab change action works in GQL headers view
77d24bc chore: account for REST params while adding description fields

📊 Changes

6 files changed (+73 additions, -29 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/collections/Properties.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/environments/teams/Details.vue (+2 -0)
📝 packages/hoppscotch-common/src/components/graphql/Headers.vue (+8 -12)
📝 packages/hoppscotch-common/src/components/graphql/RequestOptions.vue (+6 -0)
📝 packages/hoppscotch-common/src/components/http/Headers.vue (+7 -1)
📝 packages/hoppscotch-selfhost-web/src/platform/collections/collections.platform.ts (+44 -16)

📄 Description

This PR includes a fix for the following issues:-

Bulk mode editor wasn't visible in the collection properties modal.
Attempting to create an environment from a team workspace without specifying a name will result in an infinite loading state regardless of reopening the modal since the component doesn't unmount.
The Go to Authorization tab action from the headers view under the REST/GQL collection properties modal and under the GQL request didn't have an effect.

Also, a few type errors are resolved and proper migrations are added while resolving the headers field in the syncing context.

What's changed

The absolute property for the header bulk editor is disabled for the collection property modal.
The latest version of HoppCollection is specified while pulling collections from upstream to update the store in the syncing context. Also, a relevant migration step is added to ensure the addition of a description under the REST/GQL headers (collection/request level) & REST params fields via a new addDescriptionField() helper function.
Toggle back the loading state if attempting to create an environment from a team workspace without specifying a name.
Bind action handler for the Go to Authorization tab action in the collection properties modal and GraphQL request headers view.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4309 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 8/29/2024 **Status:** ✅ Merged **Merged:** 8/30/2024 **Merged by:** [@nivedin](https://github.com/nivedin) **Base:** `next` ← **Head:** `fix/collection-header-properties-bulk-editor-bug` --- ### 📝 Commits (6) - [`01c6ff6`](https://github.com/hoppscotch/hoppscotch/commit/01c6ff606b763e37a7d5d1cfe52539fd2f944706) fix: collection properties header bulk update editor bug - [`0d1bb06`](https://github.com/hoppscotch/hoppscotch/commit/0d1bb068b38452b3041155d58f09604db847eeb2) chore: add migration step while resolving `headers` in the syncing context - [`5a38f4e`](https://github.com/hoppscotch/hoppscotch/commit/5a38f4e1318b8e4aad06b6169f68b683b3edccbf) fix: prevent inifinite loading state in add environments modal - [`fae54fb`](https://github.com/hoppscotch/hoppscotch/commit/fae54fb349e69831a038d368ac70c2351b6308b7) fix: tab change when clicking computed auth - [`e6a4f48`](https://github.com/hoppscotch/hoppscotch/commit/e6a4f48a0d86a9dcad11c37f3712735cd4693777) fix: ensure tab change action works in GQL headers view - [`77d24bc`](https://github.com/hoppscotch/hoppscotch/commit/77d24bcf1c6d68a44e1d7ad8e7e6a0c75c5da60d) chore: account for REST params while adding description fields ### 📊 Changes **6 files changed** (+73 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/collections/Properties.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/environments/teams/Details.vue` (+2 -0) 📝 `packages/hoppscotch-common/src/components/graphql/Headers.vue` (+8 -12) 📝 `packages/hoppscotch-common/src/components/graphql/RequestOptions.vue` (+6 -0) 📝 `packages/hoppscotch-common/src/components/http/Headers.vue` (+7 -1) 📝 `packages/hoppscotch-selfhost-web/src/platform/collections/collections.platform.ts` (+44 -16) </details> ### 📄 Description This PR includes a fix for the following issues:- - Bulk mode editor wasn't visible in the collection properties modal. - Attempting to create an environment from a team workspace without specifying a name will result in an infinite loading state regardless of reopening the modal since the component doesn't unmount. - The `Go to Authorization tab` action from the headers view under the REST/GQL collection properties modal and under the GQL request didn't have an effect. Also, a few type errors are resolved and proper migrations are added while resolving the `headers` field in the syncing context. ### What's changed - The `absolute` property for the header bulk editor is disabled for the collection property modal. - The latest version of `HoppCollection` is specified while pulling collections from upstream to update the store in the syncing context. Also, a relevant migration step is added to ensure the addition of a `description` under the REST/GQL `headers` (collection/request level) & REST params fields via a new `addDescriptionField()` helper function. - Toggle back the loading state if attempting to create an environment from a team workspace without specifying a name. - Bind action handler for the `Go to Authorization tab` action in the collection properties modal and GraphQL request headers view. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>