[PR #4284] [MERGED] fix: persist request execution context between tabs #4734

New issue

Closed

opened 2026-03-17 02:14:35 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:14:35 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4284
Author: @nivedin
Created: 8/22/2024
Status: ✅ Merged
Merged: 8/22/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/request-send-btn-loading-text

📝 Commits (2)

d2f8af0 chore: use tab response loading state for request button
c6838f9 chore: add tab specific cancel function

📊 Changes

3 files changed (+18 additions, -7 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/Request.vue (+12 -7)
📝 packages/hoppscotch-common/src/helpers/rest/document.ts (+5 -0)
📝 packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts (+1 -0)

📄 Description

Closes #4271 HFE-565

This PR fixes the bug where when sending a request in tab1, the button send changes to cancel. Before the request finishes switching to tab2 and back to tab1, the cancel button disappears.

What's changed

The text now depends on the tab response loading state rather than a component-level loading value. Also, a new field cancelFunction is added under the tab document HoppRESTDocument to keep a reference to the cancel function to cancel the current request in execution.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4284 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 8/22/2024 **Status:** ✅ Merged **Merged:** 8/22/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/request-send-btn-loading-text` --- ### 📝 Commits (2) - [`d2f8af0`](https://github.com/hoppscotch/hoppscotch/commit/d2f8af0d9415d7f887928320cd5f14b102788fe6) chore: use tab response loading state for request button - [`c6838f9`](https://github.com/hoppscotch/hoppscotch/commit/c6838f91924b33fb5c963fe5fc1f9909d120d947) chore: add tab specific cancel function ### 📊 Changes **3 files changed** (+18 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/Request.vue` (+12 -7) 📝 `packages/hoppscotch-common/src/helpers/rest/document.ts` (+5 -0) 📝 `packages/hoppscotch-common/src/services/persistence/validation-schemas/index.ts` (+1 -0) </details> ### 📄 Description Closes #4271 HFE-565 This PR fixes the bug where when sending a request in tab1, the button `send` changes to `cancel`. Before the request finishes switching to tab2 and back to tab1, the `cancel` button disappears. ### What's changed The text now depends on the tab response loading state rather than a component-level loading value. Also, a new field `cancelFunction` is added under the tab document `HoppRESTDocument` to keep a reference to the cancel function to cancel the current request in execution. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>