[PR #4263] [MERGED] fix: sync all settings actions in SH #4729

New issue

Closed

opened 2026-03-17 02:14:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:14:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4263
Author: @jamesgeorge007
Created: 8/14/2024
Status: ✅ Merged
Merged: 8/19/2024
Merged by: @AndrewBastin

Base: patch ← Head: fix/sh-settings-sync

📝 Commits (2)

e9fdc1b fix: sync all settings actions in SH
84aeda1 fix: prevent exceptions while toggling synchronization settings

📊 Changes

4 files changed (+22 additions, -4 deletions)

View changed files

📝 packages/hoppscotch-selfhost-desktop/src/lib/sync/index.ts (+2 -2)
📝 packages/hoppscotch-selfhost-desktop/src/platform/settings/settings.sync.ts (+9 -0)
📝 packages/hoppscotch-selfhost-web/src/lib/sync/index.ts (+2 -2)
📝 packages/hoppscotch-selfhost-web/src/platform/settings/settings.sync.ts (+9 -0)

📄 Description

What's changed

Previously, actions over the following settings were not getting synced in SH:

Expand navigation & Sidebar on left under Experiments.
Spotlight open status.
Wrap lines preference under request params, headers in bulk mode, etc.
Collections, Environments & History synchronization settings under the profile page.

This was the case since the relevant store dispatcher methods were not present under the store sync definition maintained at the platform level. This PR resolves this behaviour by extending the above definition accordingly. There was also a known issue with toggling the synchronization settings (Collections, Environments & History) under the profile page resulting in an exception which is fixed by adding safeguards with the usage of startSubscriptions() & stopSubscriptions() function calls from the syncing context.

Closes HFE-324 HFE-561.

Notes to reviewers

While verifying the wrap lines preference toggle sync behaviour, make sure to check all request tabs applicable to the action.

github.com/hoppscotch/hoppscotch@3f78bf1062/packages/hoppscotch-common/src/newstore/settings.ts (L32-L49)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4263 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 8/14/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `patch` ← **Head:** `fix/sh-settings-sync` --- ### 📝 Commits (2) - [`e9fdc1b`](https://github.com/hoppscotch/hoppscotch/commit/e9fdc1b6afecba2dad82078f7aae9453c94887a4) fix: sync all settings actions in SH - [`84aeda1`](https://github.com/hoppscotch/hoppscotch/commit/84aeda1477f484e55327d03dcc449f3bcdc90099) fix: prevent exceptions while toggling synchronization settings ### 📊 Changes **4 files changed** (+22 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-selfhost-desktop/src/lib/sync/index.ts` (+2 -2) 📝 `packages/hoppscotch-selfhost-desktop/src/platform/settings/settings.sync.ts` (+9 -0) 📝 `packages/hoppscotch-selfhost-web/src/lib/sync/index.ts` (+2 -2) 📝 `packages/hoppscotch-selfhost-web/src/platform/settings/settings.sync.ts` (+9 -0) </details> ### 📄 Description ### What's changed Previously, actions over the following settings were not getting synced in SH: - `Expand navigation` & `Sidebar on left` under `Experiments`. - Spotlight open status. - Wrap lines preference under request params, headers in bulk mode, etc. - `Collections`, `Environments` & `History` synchronization settings under the profile page. This was the case since the relevant store dispatcher methods were not present under the store sync definition maintained at the platform level. This PR resolves this behaviour by extending the above definition accordingly. There was also a known issue with toggling the synchronization settings (`Collections`, `Environments` & `History`) under the profile page resulting in an exception which is fixed by adding safeguards with the usage of `startSubscriptions()` & `stopSubscriptions()` function calls from the syncing context. Closes HFE-324 HFE-561. ### Notes to reviewers While verifying the wrap lines preference toggle sync behaviour, make sure to check all request tabs applicable to the action. https://github.com/hoppscotch/hoppscotch/blob/3f78bf10621eb2c6574f3a19f6169aeda016d69b/packages/hoppscotch-common/src/newstore/settings.ts#L32-L49 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>