[PR #4255] [MERGED] fix: reset currentEnv if there is a shared workspace change #4726

Closed
opened 2026-03-17 02:14:18 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4255
Author: @nivedin
Created: 8/13/2024
Status: Merged
Merged: 8/19/2024
Merged by: @nivedin

Base: patchHead: fix/shared-workspace-env-invaidate


📝 Commits (2)

  • 9aa0adb fix: reset currentEnv if there is a shared workspace change
  • 5762058 chore: cleanup

📊 Changes

2 files changed (+19 additions, -9 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/index.vue (+18 -7)
📝 packages/hoppscotch-common/src/services/secret-environment.service.ts (+1 -2)

📄 Description

Closes HFE-560

This PR fixes the a bug in the environment selector where the current environment was not getting invalidated while switching shared workspaces.

The current environment flow will be as following -

  • user has a personal env selected, changes to a shared workspace - selected env does not change
  • user has a team env selected, changes to another shared workspace or personal workspace- change current env to NO_ENV_SELECTED

What's changed

Current selected environment switches to NO_ENV_SELECTED if there is switch in shared workspace.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4255 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 8/13/2024 **Status:** ✅ Merged **Merged:** 8/19/2024 **Merged by:** [@nivedin](https://github.com/nivedin) **Base:** `patch` ← **Head:** `fix/shared-workspace-env-invaidate` --- ### 📝 Commits (2) - [`9aa0adb`](https://github.com/hoppscotch/hoppscotch/commit/9aa0adba0477fdf232d6a1595196d4caadb773d0) fix: reset currentEnv if there is a shared workspace change - [`5762058`](https://github.com/hoppscotch/hoppscotch/commit/5762058089a6c2f23bfa7b7b6d62023e3bc21c14) chore: cleanup ### 📊 Changes **2 files changed** (+19 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/index.vue` (+18 -7) 📝 `packages/hoppscotch-common/src/services/secret-environment.service.ts` (+1 -2) </details> ### 📄 Description Closes HFE-560 This PR fixes the a bug in the environment selector where the current environment was not getting invalidated while switching shared workspaces. The current environment flow will be as following - - user has a personal env selected, changes to a shared workspace - selected env does not change - user has a team env selected, changes to another shared workspace or personal workspace- change current env to `NO_ENV_SELECTED` ### What's changed Current selected environment switches to `NO_ENV_SELECTED` if there is switch in shared workspace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:14:18 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4726
No description provided.