[PR #4245] [MERGED] chore: hide duplicate Global environment action for a team workspace #4725

Closed
opened 2026-03-17 02:14:02 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4245
Author: @jamesgeorge007
Created: 8/7/2024
Status: Merged
Merged: 8/7/2024
Merged by: @jamesgeorge007

Base: patchHead: copy-text-update


📝 Commits (2)

  • 4453968 chore: update duplicate Global environment action copy text
  • ad71c4e chore: hide duplicate Global environment action for a team workspace

📊 Changes

2 files changed (+39 additions, -25 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/environments/index.vue (+6 -1)
📝 packages/hoppscotch-common/src/components/environments/my/Environment.vue (+33 -24)

📄 Description

Description

Duplicating the Global environment is an action specific to the personal workspace. The above context isn't conveyed while attempting the action from a team workspace. New environment entries are added under the personal workspace with a success toast. This PR hides the Global environment duplicate action while at a team workspace. The same action via spotlight is enabled regardless of the active workspace.

Closes HFE-554.

Preview

https://github.com/user-attachments/assets/0b16eb2c-6c91-446d-9302-13377ec0ef2c

What's changed

  • A new prop showDuplicateActions added under the EnvironmentsMyEnvironment component that defaults to true. It is set based on the active workspace type for the Global environment entry.
  • Compile repeated checks in computed properties.
  • Resolves a few pre-existing type errors found in scope.

Note to reviewers

Initially, a copy text update was proposed to convey the behavior and later it was decided to be explicit and disable the duplicate action while at a team workspace.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4245 **Author:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Created:** 8/7/2024 **Status:** ✅ Merged **Merged:** 8/7/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `copy-text-update` --- ### 📝 Commits (2) - [`4453968`](https://github.com/hoppscotch/hoppscotch/commit/4453968306e5748fb82b8017cdde1ccc3b1bf367) chore: update duplicate `Global environment` action copy text - [`ad71c4e`](https://github.com/hoppscotch/hoppscotch/commit/ad71c4ec5a5cab2e9319136b0443a437d79fd964) chore: hide duplicate `Global environment` action for a team workspace ### 📊 Changes **2 files changed** (+39 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/environments/index.vue` (+6 -1) 📝 `packages/hoppscotch-common/src/components/environments/my/Environment.vue` (+33 -24) </details> ### 📄 Description ### Description Duplicating the `Global environment` is an action specific to the personal workspace. The above context isn't conveyed while attempting the action from a team workspace. New environment entries are added under the personal workspace with a success toast. This PR hides the `Global environment` duplicate action while at a team workspace. The same action via spotlight is enabled regardless of the active workspace. Closes HFE-554. ### Preview https://github.com/user-attachments/assets/0b16eb2c-6c91-446d-9302-13377ec0ef2c ### What's changed - A new prop `showDuplicateActions` added under the `EnvironmentsMyEnvironment` component that defaults to `true`. It is set based on the active workspace type for the `Global environment` entry. - Compile repeated checks in computed properties. - Resolves a few pre-existing type errors found in scope. ### Note to reviewers Initially, a copy text update was proposed to convey the behavior and later it was decided to be explicit and disable the duplicate action while at a team workspace. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:14:02 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4725
No description provided.