mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4245] [MERGED] chore: hide duplicate Global environment action for a team workspace #4725
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4725
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4245
Author: @jamesgeorge007
Created: 8/7/2024
Status: ✅ Merged
Merged: 8/7/2024
Merged by: @jamesgeorge007
Base:
patch← Head:copy-text-update📝 Commits (2)
4453968chore: update duplicateGlobal environmentaction copy textad71c4echore: hide duplicateGlobal environmentaction for a team workspace📊 Changes
2 files changed (+39 additions, -25 deletions)
View changed files
📝
packages/hoppscotch-common/src/components/environments/index.vue(+6 -1)📝
packages/hoppscotch-common/src/components/environments/my/Environment.vue(+33 -24)📄 Description
Description
Duplicating the
Global environmentis an action specific to the personal workspace. The above context isn't conveyed while attempting the action from a team workspace. New environment entries are added under the personal workspace with a success toast. This PR hides theGlobal environmentduplicate action while at a team workspace. The same action via spotlight is enabled regardless of the active workspace.Closes HFE-554.
Preview
https://github.com/user-attachments/assets/0b16eb2c-6c91-446d-9302-13377ec0ef2c
What's changed
showDuplicateActionsadded under theEnvironmentsMyEnvironmentcomponent that defaults totrue. It is set based on the active workspace type for theGlobal environmententry.Note to reviewers
Initially, a copy text update was proposed to convey the behavior and later it was decided to be explicit and disable the duplicate action while at a team workspace.
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.