[PR #4238] [MERGED] fix: add to parameters regex #4717

Closed
opened 2026-03-17 02:13:46 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4238
Author: @ajmalmohad
Created: 8/4/2024
Status: Merged
Merged: 8/6/2024
Merged by: @nivedin

Base: patchHead: fix/add-params-regex


📝 Commits (1)

  • ad72249 fix: add to parameters regex

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-common/src/services/context-menu/menu/parameter.menu.ts (+1 -1)

📄 Description

Closes #4234

What's changed

  • The regex for parsing parameters has changed to support more valid url parameters
  • It is able to parse more complicated key values like a lot of online parsers

Notes to reviewers

The key can contain any character expect '&' and a '='
A value can contain any character expect a '&' (which will start the next key) - it can include a '='

Reference: https://semalt.tools/en/url-parser


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4238 **Author:** [@ajmalmohad](https://github.com/ajmalmohad) **Created:** 8/4/2024 **Status:** ✅ Merged **Merged:** 8/6/2024 **Merged by:** [@nivedin](https://github.com/nivedin) **Base:** `patch` ← **Head:** `fix/add-params-regex` --- ### 📝 Commits (1) - [`ad72249`](https://github.com/hoppscotch/hoppscotch/commit/ad72249fbc37db5545ded42d441648d68529969d) fix: add to parameters regex ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/services/context-menu/menu/parameter.menu.ts` (+1 -1) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes #4234 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> - The regex for parsing parameters has changed to support more valid url parameters - It is able to parse more complicated key values like a lot of online parsers <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Notes to reviewers The key can contain any character expect '&' and a '=' A value can contain any character expect a '&' (which will start the next key) - it can include a '=' Reference: https://semalt.tools/en/url-parser <!-- Any information you feel the reviewer should know about when reviewing your PR --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:13:46 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4717
No description provided.