[PR #4219] [MERGED] fix: infra token expriry check on guard #4706

Closed
opened 2026-03-17 02:13:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4219
Author: @mirarifhasan
Created: 7/29/2024
Status: Merged
Merged: 7/29/2024
Merged by: @balub

Base: nextHead: fix/infra-token-expriry-check


📝 Commits (1)

  • db6f870 fix: null check added in infraToken expiry check on guard

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 packages/hoppscotch-backend/src/guards/infra-token.guard.ts (+1 -1)

📄 Description

What's changed

This PR resolves an bug on infra-token.guard.ts while checking the token is expire or not. expiryOn value can be null. So, this PR cover that conditions as well.

Notes to reviewers

Nil


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4219 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 7/29/2024 **Status:** ✅ Merged **Merged:** 7/29/2024 **Merged by:** [@balub](https://github.com/balub) **Base:** `next` ← **Head:** `fix/infra-token-expriry-check` --- ### 📝 Commits (1) - [`db6f870`](https://github.com/hoppscotch/hoppscotch/commit/db6f8700af50f41f3bbbd79420fe8dc1e9345c3e) fix: null check added in infraToken expiry check on guard ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-backend/src/guards/infra-token.guard.ts` (+1 -1) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> <!-- Issue # here --> <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> This PR resolves an bug on `infra-token.guard.ts` while checking the token is expire or not. `expiryOn` value can be `null`. So, this PR cover that conditions as well. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Notes to reviewers <!-- Any information you feel the reviewer should know about when reviewing your PR --> Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:13:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4706
No description provided.