[PR #4194] [MERGED] feat: Ability to toggle cookies to work in HTTP #4697

Closed
opened 2026-03-17 02:12:40 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4194
Author: @balub
Created: 7/17/2024
Status: Merged
Merged: 7/24/2024
Merged by: @balub

Base: nextHead: feat/secure-cookies-toggle


📝 Commits (4)

  • 3023c13 feat: added new env variable
  • aa86aa4 feat: made http secure cookie conditional
  • 27d0392 chore: added comments to env files
  • ca794a3 chore: changed target of hopp-old-backend service to prod

📊 Changes

2 files changed (+5 additions, -2 deletions)

View changed files

📝 .env.example (+3 -0)
📝 packages/hoppscotch-backend/src/auth/helper.ts (+2 -2)

📄 Description

Closes HSB-459

What's changed

In this PR, we are introducing a new environment variable ALLOW_SECURE_COOKIES which can be used to toggle if the cookies generated by the Hoppscotch backend should be used over HTTP.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

None


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4194 **Author:** [@balub](https://github.com/balub) **Created:** 7/17/2024 **Status:** ✅ Merged **Merged:** 7/24/2024 **Merged by:** [@balub](https://github.com/balub) **Base:** `next` ← **Head:** `feat/secure-cookies-toggle` --- ### 📝 Commits (4) - [`3023c13`](https://github.com/hoppscotch/hoppscotch/commit/3023c13fc19833973e018b505ad7b79766164a92) feat: added new env variable - [`aa86aa4`](https://github.com/hoppscotch/hoppscotch/commit/aa86aa43a23b0725467c2921bb615e2ae755f651) feat: made http secure cookie conditional - [`27d0392`](https://github.com/hoppscotch/hoppscotch/commit/27d0392afe17d87b2d5a86c1cff0db888fafb6b3) chore: added comments to env files - [`ca794a3`](https://github.com/hoppscotch/hoppscotch/commit/ca794a3e67d09dbfdefff7a99ee497bc672697e0) chore: changed target of hopp-old-backend service to prod ### 📊 Changes **2 files changed** (+5 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+3 -0) 📝 `packages/hoppscotch-backend/src/auth/helper.ts` (+2 -2) </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> Closes HSB-459 <!-- Add an introduction into what this PR tries to solve in a couple of sentences --> ### What's changed <!-- Describe point by point the different things you have changed in this PR --> In this PR, we are introducing a new environment variable `ALLOW_SECURE_COOKIES` which can be used to toggle if the cookies generated by the Hoppscotch backend should be used over HTTP. <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behaviour, etc. --> None --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:12:40 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4697
No description provided.