[PR #4181] [MERGED] fix: embeds response and request option section getting hidden bug #4691

New issue

Closed

opened 2026-03-17 02:12:24 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:12:24 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4181
Author: @nivedin
Created: 7/11/2024
Status: ✅ Merged
Merged: 7/18/2024
Merged by: @jamesgeorge007

Base: patch ← Head: fix/embed-response-bug

📝 Commits (6)

6c010ed fix: add height to embed sections
3ea2edc chore: add flex to codemirror parent
2c8d9c0 chore: add panes to embed and some refactors
c012c2f chore: minor refactor
6a85c1e chore: minor update
d97aceb chore: specify flex-direction for bulk mode editor

📊 Changes

13 files changed (+251 additions, -196 deletions)

View changed files

📝 packages/hoppscotch-common/src/components.d.ts (+2 -0)
📝 packages/hoppscotch-common/src/components/app/PaneLayout.vue (+5 -1)
➕ packages/hoppscotch-common/src/components/embeds/Header.vue (+33 -0)
➕ packages/hoppscotch-common/src/components/embeds/Request.vue (+185 -0)
📝 packages/hoppscotch-common/src/components/embeds/index.vue (+18 -187)
📝 packages/hoppscotch-common/src/components/http/Headers.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/Parameters.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/RawBody.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/RequestVariables.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/http/URLEncodedParams.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue (+1 -1)
📝 packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue (+1 -1)
📝 packages/hoppscotch-common/src/pages/e/_id.vue (+1 -1)

📄 Description

Closes HFE-539, #4170

This PR fixes the UI bug in embeds where the response and some request option codemirror instance was hidden.

https://github.com/hoppscotch/hoppscotch/assets/53208152/1ecf44a8-011a-4997-a58b-949f511830d7

What's changed

The embeds structure have been updated by using PaneLayout for the view, now the user can set their prefered height, also some code refactor has been done for the Embeds component.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4181 **Author:** [@nivedin](https://github.com/nivedin) **Created:** 7/11/2024 **Status:** ✅ Merged **Merged:** 7/18/2024 **Merged by:** [@jamesgeorge007](https://github.com/jamesgeorge007) **Base:** `patch` ← **Head:** `fix/embed-response-bug` --- ### 📝 Commits (6) - [`6c010ed`](https://github.com/hoppscotch/hoppscotch/commit/6c010ed6c91783d885018d546ed8b82760610e56) fix: add height to embed sections - [`3ea2edc`](https://github.com/hoppscotch/hoppscotch/commit/3ea2edc8fc7700e254d8f8dd8380385fb4fecd97) chore: add flex to codemirror parent - [`2c8d9c0`](https://github.com/hoppscotch/hoppscotch/commit/2c8d9c057d3b256bc2daa2030dc86d012e0f885a) chore: add panes to embed and some refactors - [`c012c2f`](https://github.com/hoppscotch/hoppscotch/commit/c012c2fb10ab6b1afaaf0a2166adb9ed5c72441a) chore: minor refactor - [`6a85c1e`](https://github.com/hoppscotch/hoppscotch/commit/6a85c1e909b74a052a43fc152e5651b242c0b200) chore: minor update - [`d97aceb`](https://github.com/hoppscotch/hoppscotch/commit/d97aceb5b0883cb0b4c80a84685c0343ada5ee59) chore: specify `flex-direction` for bulk mode editor ### 📊 Changes **13 files changed** (+251 additions, -196 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components.d.ts` (+2 -0) 📝 `packages/hoppscotch-common/src/components/app/PaneLayout.vue` (+5 -1) ➕ `packages/hoppscotch-common/src/components/embeds/Header.vue` (+33 -0) ➕ `packages/hoppscotch-common/src/components/embeds/Request.vue` (+185 -0) 📝 `packages/hoppscotch-common/src/components/embeds/index.vue` (+18 -187) 📝 `packages/hoppscotch-common/src/components/http/Headers.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/Parameters.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/RawBody.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/RequestVariables.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/http/URLEncodedParams.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/JSONLensRenderer.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/components/lenses/renderers/RawLensRenderer.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/pages/e/_id.vue` (+1 -1) </details> ### 📄 Description Closes HFE-539, #4170 This PR fixes the UI bug in embeds where the response and some request option codemirror instance was hidden. https://github.com/hoppscotch/hoppscotch/assets/53208152/1ecf44a8-011a-4997-a58b-949f511830d7 ### What's changed The embeds structure have been updated by using `PaneLayout` for the view, now the user can set their prefered height, also some code refactor has been done for the `Embeds` component. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>