[PR #4114] [MERGED] fix: make client credential optional in authcode + pkce flow #4673

New issue

Closed

opened 2026-03-17 02:11:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:11:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4114
Author: @amk-dev
Created: 6/11/2024
Status: ✅ Merged
Merged: 6/12/2024
Merged by: @nivedin

Base: patch ← Head: fix/client-credential-optional

📝 Commits (2)

dfa96d8 fix: make client credential optional
72e3f0b test: update test fixtures

📊 Changes

7 files changed (+140 additions, -20 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue (+1 -1)
📝 packages/hoppscotch-common/src/services/oauth/flows/authCode.ts (+1 -2)
📝 packages/hoppscotch-common/src/services/persistence/__tests__/__mocks__/index.ts (+6 -6)
📝 packages/hoppscotch-data/src/graphql/index.ts (+6 -4)
➕ packages/hoppscotch-data/src/graphql/v/5.ts (+47 -0)
📝 packages/hoppscotch-data/src/rest/index.ts (+13 -7)
➕ packages/hoppscotch-data/src/rest/v/5.ts (+66 -0)

📄 Description

Closes #3784
Fixes HFE-517

Changes

This PR makes the clientSecret optional for authcode + pkce flow. since this is a schema change, we introduce new version 5 for our rest and graphql auth schema in hoppscotch-data.

Note: if you're reviewing and need credentials to test. hit me up on slack.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4114 **Author:** [@amk-dev](https://github.com/amk-dev) **Created:** 6/11/2024 **Status:** ✅ Merged **Merged:** 6/12/2024 **Merged by:** [@nivedin](https://github.com/nivedin) **Base:** `patch` ← **Head:** `fix/client-credential-optional` --- ### 📝 Commits (2) - [`dfa96d8`](https://github.com/hoppscotch/hoppscotch/commit/dfa96d8c4236c13a21ec832f3f378e5d1a0f20ec) fix: make client credential optional - [`72e3f0b`](https://github.com/hoppscotch/hoppscotch/commit/72e3f0bc2b35405852f9a5f8e40b01aecac89dcc) test: update test fixtures ### 📊 Changes **7 files changed** (+140 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/http/OAuth2Authorization.vue` (+1 -1) 📝 `packages/hoppscotch-common/src/services/oauth/flows/authCode.ts` (+1 -2) 📝 `packages/hoppscotch-common/src/services/persistence/__tests__/__mocks__/index.ts` (+6 -6) 📝 `packages/hoppscotch-data/src/graphql/index.ts` (+6 -4) ➕ `packages/hoppscotch-data/src/graphql/v/5.ts` (+47 -0) 📝 `packages/hoppscotch-data/src/rest/index.ts` (+13 -7) ➕ `packages/hoppscotch-data/src/rest/v/5.ts` (+66 -0) </details> ### 📄 Description Closes #3784 Fixes HFE-517 **Changes** This PR makes the `clientSecret` optional for authcode + pkce flow. since this is a schema change, we introduce new version 5 for our rest and graphql auth schema in `hoppscotch-data`. Note: if you're reviewing and need credentials to test. hit me up on slack. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>