[PR #4123] [MERGED] refactor(common): improvements to banner handling logic #4672

New issue

Closed

opened 2026-03-17 02:11:18 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:11:18 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4123
Author: @joeljstephen
Created: 6/14/2024
Status: ✅ Merged
Merged: 6/25/2024
Merged by: @AndrewBastin

Base: next ← Head: refactor/banner-types

📝 Commits (9)

ba158cb feat: new custom banner id and updated types introduced to banner service
b2a5bd2 refactor: updated types in banner component
8311d40 refactor: provide provision to remove current banner using current banner id
551a392 refactor: lowered priority of offline banner
6cf6d3e refactor: reverted banner types from using enums to union types
a1ad74b refactor: updated banner types naming
65371c0 refactor: provided assertion to bannerList value
1e8c2d7 refactor: removed current banner id
c28526f chore: code cleanup

📊 Changes

1 file changed (+25 additions, -18 deletions)

View changed files

📝 packages/hoppscotch-common/src/components/app/Header.vue (+25 -18)

📄 Description

Ticket

Closes HFE-524

Description

This PR brings about improvements to the handling of banners in the app

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4123 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 6/14/2024 **Status:** ✅ Merged **Merged:** 6/25/2024 **Merged by:** [@AndrewBastin](https://github.com/AndrewBastin) **Base:** `next` ← **Head:** `refactor/banner-types` --- ### 📝 Commits (9) - [`ba158cb`](https://github.com/hoppscotch/hoppscotch/commit/ba158cb0040b24b55e45e23b97a0b882530f09c1) feat: new custom banner id and updated types introduced to banner service - [`b2a5bd2`](https://github.com/hoppscotch/hoppscotch/commit/b2a5bd28ad15f3c1d687bcfd469150e030e61478) refactor: updated types in banner component - [`8311d40`](https://github.com/hoppscotch/hoppscotch/commit/8311d40272e0584698a165ab444273e5124825e1) refactor: provide provision to remove current banner using current banner id - [`551a392`](https://github.com/hoppscotch/hoppscotch/commit/551a392a13cf5c43c03e2ebec62179a283af62bc) refactor: lowered priority of offline banner - [`6cf6d3e`](https://github.com/hoppscotch/hoppscotch/commit/6cf6d3e36ee0f40e79ef90fd500deb98936f4ca3) refactor: reverted banner types from using enums to union types - [`a1ad74b`](https://github.com/hoppscotch/hoppscotch/commit/a1ad74bb72bb9612d1cb73d031523a8e63a2cace) refactor: updated banner types naming - [`65371c0`](https://github.com/hoppscotch/hoppscotch/commit/65371c0201c30dcd7b80e2e0070da8ec03917c38) refactor: provided assertion to bannerList value - [`1e8c2d7`](https://github.com/hoppscotch/hoppscotch/commit/1e8c2d7f59d6b5fbdc670898e5acc9cc8e34258f) refactor: removed current banner id - [`c28526f`](https://github.com/hoppscotch/hoppscotch/commit/c28526fd9d05ab92c3633718d6dbee75b4b39806) chore: code cleanup ### 📊 Changes **1 file changed** (+25 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-common/src/components/app/Header.vue` (+25 -18) </details> ### 📄 Description ### Ticket Closes HFE-524 ### Description This PR brings about improvements to the handling of banners in the app ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>