[PR #4081] [MERGED] fix(sh-admin): saving changes to server configurations post a failed attempt will require a page reload in dashboard #4658

New issue

Closed

opened 2026-03-17 02:10:29 +03:00 by kerem · 0 comments

kerem commented

2026-03-17 02:10:29 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4081
Author: @joeljstephen
Created: 5/22/2024
Status: ✅ Merged
Merged: 6/3/2024
Merged by: @nivedin

Base: patch ← Head: fix/dashboard-server-restart

📝 Commits (3)

1dc151d fix: resolved an issue with server restart component
787656d refactor: early return if any mutation fails when initiating server restart
88918fc fix: ensure further attempts go through after a failed reset configs action

📊 Changes

4 files changed (+29 additions, -14 deletions)

View changed files

📝 packages/hoppscotch-sh-admin/src/components.d.ts (+0 -6)
📝 packages/hoppscotch-sh-admin/src/components/settings/Reset.vue (+5 -1)
📝 packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue (+23 -7)
📝 packages/hoppscotch-sh-admin/src/pages/settings.vue (+1 -0)

📄 Description

Ticket

Closes HFE-515

Description

This PR addresses an issue on the admin dashboard where, when an attempt is made to change server configurations and a mutation error has occurred, after the relevant error toast is displayed, any subsequent attempts to save additional changes to configs fail to trigger the server restart and confirmation modals. This prevents users from making further changes unless they reload the page. This issue is resolved in this PR.

Checks

My pull request adheres to the code style of this project
My code requires changes to the documentation
I have updated the documentation as required
All the tests have passed

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4081 **Author:** [@joeljstephen](https://github.com/joeljstephen) **Created:** 5/22/2024 **Status:** ✅ Merged **Merged:** 6/3/2024 **Merged by:** [@nivedin](https://github.com/nivedin) **Base:** `patch` ← **Head:** `fix/dashboard-server-restart` --- ### 📝 Commits (3) - [`1dc151d`](https://github.com/hoppscotch/hoppscotch/commit/1dc151d6cbab1c18b3bde9ddee0583570efb7228) fix: resolved an issue with server restart component - [`787656d`](https://github.com/hoppscotch/hoppscotch/commit/787656d95bff103dd5f9b1bfbcc5a2d973ff8ed4) refactor: early return if any mutation fails when initiating server restart - [`88918fc`](https://github.com/hoppscotch/hoppscotch/commit/88918fc0c0967829b192bcfae026cd2f17e14c09) fix: ensure further attempts go through after a failed reset configs action ### 📊 Changes **4 files changed** (+29 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `packages/hoppscotch-sh-admin/src/components.d.ts` (+0 -6) 📝 `packages/hoppscotch-sh-admin/src/components/settings/Reset.vue` (+5 -1) 📝 `packages/hoppscotch-sh-admin/src/components/settings/ServerRestart.vue` (+23 -7) 📝 `packages/hoppscotch-sh-admin/src/pages/settings.vue` (+1 -0) </details> ### 📄 Description ### Ticket Closes HFE-515 ### Description This PR addresses an issue on the admin dashboard where, when an attempt is made to change server configurations and a mutation error has occurred, after the relevant error toast is displayed, any subsequent attempts to save additional changes to configs fail to trigger the server restart and confirmation modals. This prevents users from making further changes unless they reload the page. This issue is resolved in this PR. ### Checks  - [x] My pull request adheres to the code style of this project - [ ] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>