[PR #4078] [MERGED] HSB-439 feature: invite link with SMTP optional #4655

Closed
opened 2026-03-17 02:10:13 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/hoppscotch/hoppscotch/pull/4078
Author: @mirarifhasan
Created: 5/20/2024
Status: Merged
Merged: 6/27/2024
Merged by: @balub

Base: nextHead: feat/invite-link


📝 Commits (10+)

  • c26e2ee feat: env variable added in infra-config for smtp enable status
  • b28a5cc feat: event emitter added
  • 8b5df6b feat: added advance mailer configurations from infra config
  • bb6cc8f test: fix test cases
  • d948f19 feat: added query to see is smtp enabled or not
  • 7e63e8a feat: email auth provider disabled on smtp disable
  • d8c9719 chore: restrict on update directly instead of dedicated mutation
  • 3c038df fix: feedback resolved
  • 971f5ed chore: modify mailer module
  • cc49551 chore: error handle in mailer functions

📊 Changes

22 files changed (+12773 additions, -14642 deletions)

View changed files

📝 .env.example (+12 -1)
📝 packages/hoppscotch-backend/src/access-token/access-token.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/admin/admin.service.spec.ts (+2 -0)
📝 packages/hoppscotch-backend/src/admin/infra.resolver.ts (+19 -0)
📝 packages/hoppscotch-backend/src/auth/auth.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/errors.ts (+13 -0)
📝 packages/hoppscotch-backend/src/gql-schema.ts (+2 -0)
📝 packages/hoppscotch-backend/src/infra-config/helper.ts (+43 -4)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.module.ts (+2 -1)
packages/hoppscotch-backend/src/infra-config/infra-config.resolver.ts (+20 -0)
📝 packages/hoppscotch-backend/src/infra-config/infra-config.service.ts (+106 -1)
packages/hoppscotch-backend/src/mailer/helper.ts (+58 -0)
📝 packages/hoppscotch-backend/src/mailer/mailer.module.ts (+17 -14)
📝 packages/hoppscotch-backend/src/mailer/mailer.service.ts (+12 -2)
📝 packages/hoppscotch-backend/src/shortcode/shortcode.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/team-collection/team-collection.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/types/InfraConfig.ts (+9 -0)
📝 packages/hoppscotch-backend/src/user-collection/user-collection.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/user-request/user-request.service.spec.ts (+1 -0)
📝 packages/hoppscotch-backend/src/user-settings/user-settings.service.spec.ts (+1 -0)

...and 2 more files

📄 Description

Closes HSB-439

Description

This PR

  • Makes mailer-module optional
  • Makes mailer-module more configurable

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Nil


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/hoppscotch/hoppscotch/pull/4078 **Author:** [@mirarifhasan](https://github.com/mirarifhasan) **Created:** 5/20/2024 **Status:** ✅ Merged **Merged:** 6/27/2024 **Merged by:** [@balub](https://github.com/balub) **Base:** `next` ← **Head:** `feat/invite-link` --- ### 📝 Commits (10+) - [`c26e2ee`](https://github.com/hoppscotch/hoppscotch/commit/c26e2ee130ee803a7f32241a027ff847431f2b29) feat: env variable added in infra-config for smtp enable status - [`b28a5cc`](https://github.com/hoppscotch/hoppscotch/commit/b28a5ccf903bae49282dfee3f831cb76cfb13b8f) feat: event emitter added - [`8b5df6b`](https://github.com/hoppscotch/hoppscotch/commit/8b5df6b165a27db26651a8f050f35157a197ad56) feat: added advance mailer configurations from infra config - [`bb6cc8f`](https://github.com/hoppscotch/hoppscotch/commit/bb6cc8f6a8b5419fe64977aaa5290cfe91753e12) test: fix test cases - [`d948f19`](https://github.com/hoppscotch/hoppscotch/commit/d948f190aae443ae0d89c19693d795bcc26bc13c) feat: added query to see is smtp enabled or not - [`7e63e8a`](https://github.com/hoppscotch/hoppscotch/commit/7e63e8af03f26d781729b98eac96ba98c6b4e9fc) feat: email auth provider disabled on smtp disable - [`d8c9719`](https://github.com/hoppscotch/hoppscotch/commit/d8c9719756a2f16054e2495da5b5c19fa490a57f) chore: restrict on update directly instead of dedicated mutation - [`3c038df`](https://github.com/hoppscotch/hoppscotch/commit/3c038df13139c353fa8f964e8f7184a7aac961f4) fix: feedback resolved - [`971f5ed`](https://github.com/hoppscotch/hoppscotch/commit/971f5ed0b1daaeaf4d211a995c68ecc1f5e32765) chore: modify mailer module - [`cc49551`](https://github.com/hoppscotch/hoppscotch/commit/cc4955133ddc1b309df8db0b27b8abfb62c3c4ed) chore: error handle in mailer functions ### 📊 Changes **22 files changed** (+12773 additions, -14642 deletions) <details> <summary>View changed files</summary> 📝 `.env.example` (+12 -1) 📝 `packages/hoppscotch-backend/src/access-token/access-token.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/admin/admin.service.spec.ts` (+2 -0) 📝 `packages/hoppscotch-backend/src/admin/infra.resolver.ts` (+19 -0) 📝 `packages/hoppscotch-backend/src/auth/auth.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/errors.ts` (+13 -0) 📝 `packages/hoppscotch-backend/src/gql-schema.ts` (+2 -0) 📝 `packages/hoppscotch-backend/src/infra-config/helper.ts` (+43 -4) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.module.ts` (+2 -1) ➕ `packages/hoppscotch-backend/src/infra-config/infra-config.resolver.ts` (+20 -0) 📝 `packages/hoppscotch-backend/src/infra-config/infra-config.service.ts` (+106 -1) ➕ `packages/hoppscotch-backend/src/mailer/helper.ts` (+58 -0) 📝 `packages/hoppscotch-backend/src/mailer/mailer.module.ts` (+17 -14) 📝 `packages/hoppscotch-backend/src/mailer/mailer.service.ts` (+12 -2) 📝 `packages/hoppscotch-backend/src/shortcode/shortcode.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/team-collection/team-collection.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/types/InfraConfig.ts` (+9 -0) 📝 `packages/hoppscotch-backend/src/user-collection/user-collection.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/user-request/user-request.service.spec.ts` (+1 -0) 📝 `packages/hoppscotch-backend/src/user-settings/user-settings.service.spec.ts` (+1 -0) _...and 2 more files_ </details> ### 📄 Description <!-- Thanks for creating this pull request 🤗 Please make sure that the pull request is limited to one type (docs, feature, etc.) and keep it as small as possible. You can open multiple prs instead of opening a huge one. --> <!-- If this pull request closes an issue, please mention the issue number below --> <!-- Issue # here --> Closes HSB-439 ### Description <!-- Add a brief description of the pull request --> This PR - Makes `mailer-module` optional - Makes `mailer-module` more configurable <!-- You can also choose to add a list of changes and if they have been completed or not by using the markdown to-do list syntax - [ ] Not Completed - [x] Completed --> ### Checks <!-- Make sure your pull request passes the CI checks and do check the following fields as needed - --> - [x] My pull request adheres to the code style of this project - [x] My code requires changes to the documentation - [ ] I have updated the documentation as required - [x] All the tests have passed ### Additional Information <!-- Any additional information like breaking changes, dependencies added, screenshots, comparisons between new and old behaviour, etc. --> Nil --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-17 02:10:13 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/hoppscotch#4655
No description provided.