mirror of
https://github.com/hoppscotch/hoppscotch.git
synced 2026-04-26 01:06:00 +03:00
[PR #4042] [MERGED] HSB-431 fix: email case sensitive in email provider #4636
Labels
No labels
CodeDay
a11y
browser limited
bug
bug fix
cli
core
critical
design
desktop
discussion
docker
documentation
duplicate
enterprise
feature
feature
fosshack
future
good first issue
hacktoberfest
help wanted
i18n
invalid
major
minor
need information
need testing
not applicable to hoppscotch
not reproducible
pull-request
question
refactor
resolved
sandbox
self-host
spam
stale
testmu
wip
wont fix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/hoppscotch#4636
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/hoppscotch/hoppscotch/pull/4042
Author: @mirarifhasan
Created: 5/7/2024
Status: ✅ Merged
Merged: 5/15/2024
Merged by: @balub
Base:
patch← Head:fix/email-case-sensitive📝 Commits (3)
6f23667feat: code level email insensitivity added480a5f1test: fix broken test case5d05518chore: updated testcase for findUserByEmail in user module📊 Changes
6 files changed (+34 additions, -20 deletions)
View changed files
📝
packages/hoppscotch-backend/src/admin/admin.service.spec.ts(+5 -1)📝
packages/hoppscotch-backend/src/admin/admin.service.ts(+9 -3)📝
packages/hoppscotch-backend/src/shortcode/shortcode.service.ts(+4 -1)📝
packages/hoppscotch-backend/src/team-invitation/team-invitation.service.ts(+5 -4)📝
packages/hoppscotch-backend/src/user/user.service.spec.ts(+2 -2)📝
packages/hoppscotch-backend/src/user/user.service.ts(+9 -9)📄 Description
Closes HSB-431
Closes #4027
Description
This pull request addresses a problem where user emails are treated as case-sensitive during signup. This means that signing up with
user@gmail.comandUSER@gmail.comwould create two separate user entries in the database.Solution
This PR implements logic to convert all email addresses to lowercase before saving them in the database. This ensures that regardless of the case used during signup, only one user entry will be created for the same email address.
Checks
Additional Information
Nil
🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.